fix(jcache): [Cache Tracing 19] Use comma-joined keys as span description for bulk operations#5208
Draft
adinauer wants to merge 1 commit intofeat/cache-tracing-cache-writefrom
Draft
Conversation
…tions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Member
Author
|
@sentry review |
Member
Author
|
cursor review |
Sentry Build Distribution
|
This was referenced Mar 18, 2026
Draft
Draft
fix(spring): [Cache Tracing 14] Fix cache hit detection for typed get and fix jcache docs link
#5203
Draft
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Cache Tracing)
📜 Description
Fixes span description for JCache bulk operations (
getAll,putAll,removeAll,invokeAll) to use comma-joined cache keys instead of the cache name.The Caches Module spec says the span description should be "the cache key(s), separated by commas", e.g.
article1, article2. The single-key operations already did this correctly, butstartSpanForKeyswas usingdelegate.getName()(the cache name) instead.💡 Motivation and Context
Align with the Sentry SDK span specification for cache modules. The incorrect description would show the cache name (e.g. "testCache") instead of the actual keys involved in the operation.
💚 How did you test it?
Updated unit tests for
getAll,putAll, andremoveAllto verify keys appear in the span description.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Continue aligning span operations with spec (mapping to canonical 4 ops).
#skip-changelog