feat(cache): [Cache Tracing 18] Add cache.write boolean span attribute#5207
Draft
adinauer wants to merge 1 commit intoref/cache-tracing-cache-operation-keyfrom
Draft
feat(cache): [Cache Tracing 18] Add cache.write boolean span attribute#5207adinauer wants to merge 1 commit intoref/cache-tracing-cache-operation-keyfrom
adinauer wants to merge 1 commit intoref/cache-tracing-cache-operation-keyfrom
Conversation
Set cache.write on spans across all four cache wrapper implementations to indicate whether an operation actually modified the cache. This complements the existing cache.hit attribute for read operations. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Contributor
|
This was referenced Mar 18, 2026
Draft
fix(spring): [Cache Tracing 14] Fix cache hit detection for typed get and fix jcache docs link
#5203
Draft
Sentry Build Distribution
|
This was referenced Mar 18, 2026
Draft
Member
Author
|
@sentry review |
Member
Author
|
cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This was referenced Mar 18, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Stack (Cache Tracing)
📜 Description
Adds a
CACHE_WRITE = "cache.write"constant toSpanDataConventionand sets it on spans across all four cache wrapper implementations (spring, spring-7, spring-jakarta, jcache).The value reflects whether the operation actually modified the cache:
get,getAll,retrieve): omittedput,putAll,evict,clear,invalidate,removeAll):trueputIfAbsent,replace,remove,getAndReplace,getAndRemove): based on return valueget(key, Callable),retrieve(key, Supplier)): based on whether loader was invokedinvoke,invokeAll): omitted (can't determine if EntryProcessor wrote)💡 Motivation and Context
Cache tracing spans currently track
cache.hitfor read operations, but there's no equivalent attribute indicating whether an operation actually modified the cache. Addingcache.writelets the Sentry UI show write counts/rates and helps users distinguish no-op conditional operations (e.g.putIfAbsentwhen key exists) from actual mutations.💚 How did you test it?
cache.writeassertions to all existing cache wrapper test classes📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog