chore(deps): bump actions packages to their latest major#76
chore(deps): bump actions packages to their latest major#76
Conversation
8c79c89 to
04c6612
Compare
a98ae03 to
011fd3a
Compare
IceTDrinker
left a comment
There was a problem hiding this comment.
This one looks good to go, guess #75 better get merged first
@IceTDrinker reviewed 11 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on soonum).
.github/linters/eslint.config.mjs line 2 at r1 (raw file):
// This first import triggers a linting error. // It's a false positive since this rule doesn't exist anymore in eslint 10+.
not sure I understand that one ?
.github/linters/eslint.config.mjs line 13 at r1 (raw file):
const githubFlatConfigs = github.getFlatConfigs() export default defineConfig([
no idea if this config is correct
04c6612 to
fc4080d
Compare
IceTDrinker
left a comment
There was a problem hiding this comment.
@IceTDrinker reviewed 1 file and made 1 comment.
Reviewable status: 10 of 22 files reviewed, 3 unresolved discussions (waiting on soonum).
LICENSE line 3 at r2 (raw file):
BSD 3-Clause Clear License Copyright © 2025 ZAMA.
will need a rebase for license year
Latest major version of actions/github (v9.0.0), switch from CommonJS to ESM. The code changes in this commit simply does the migration in this two javascript flavors.
dd190d2 to
74b261e
Compare
soonum
left a comment
There was a problem hiding this comment.
@soonum made 3 comments and resolved 1 discussion.
Reviewable status: 9 of 22 files reviewed, 2 unresolved discussions (waiting on IceTDrinker).
.github/linters/eslint.config.mjs line 2 at r1 (raw file):
Previously, IceTDrinker wrote…
not sure I understand that one ?
This is a problem related to import that exists in v9 of ESlint. The rule associated to this lint has been removed in v10. So we can safely disable it as long as we have v9 as dependency.
.github/linters/eslint.config.mjs line 13 at r1 (raw file):
Previously, IceTDrinker wrote…
no idea if this config is correct
That's the recommended way of setting up things from both ESLint ans super-linter documentation.
LICENSE line 3 at r2 (raw file):
Previously, IceTDrinker wrote…
will need a rebase for license year
Done
Latest major version of actions/github (v9.0.0), switch from CommonJS to ESM. The code changes in this commit simply does the migration in this two javascript flavors.
This change is