Skip to content

chore(deps): bump actions packages to their latest major#76

Open
soonum wants to merge 2 commits intomainfrom
dt/refactor/use_esm
Open

chore(deps): bump actions packages to their latest major#76
soonum wants to merge 2 commits intomainfrom
dt/refactor/use_esm

Conversation

@soonum
Copy link
Copy Markdown
Contributor

@soonum soonum commented Apr 9, 2026

Latest major version of actions/github (v9.0.0), switch from CommonJS to ESM. The code changes in this commit simply does the migration in this two javascript flavors.


This change is Reviewable

@soonum soonum requested a review from IceTDrinker April 9, 2026 08:16
@soonum soonum self-assigned this Apr 9, 2026
@soonum soonum force-pushed the dt/chore/fix_lints branch 2 times, most recently from 8c79c89 to 04c6612 Compare April 9, 2026 08:29
@soonum soonum force-pushed the dt/refactor/use_esm branch 2 times, most recently from a98ae03 to 011fd3a Compare April 9, 2026 08:43
Copy link
Copy Markdown
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to go, guess #75 better get merged first

@IceTDrinker reviewed 11 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on soonum).


.github/linters/eslint.config.mjs line 2 at r1 (raw file):

// This first import triggers a linting error.
// It's a false positive since this rule doesn't exist anymore in eslint 10+.

not sure I understand that one ?


.github/linters/eslint.config.mjs line 13 at r1 (raw file):

const githubFlatConfigs = github.getFlatConfigs()

export default defineConfig([

no idea if this config is correct

@soonum soonum force-pushed the dt/chore/fix_lints branch from 04c6612 to fc4080d Compare April 15, 2026 09:26
Copy link
Copy Markdown
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IceTDrinker reviewed 1 file and made 1 comment.
Reviewable status: 10 of 22 files reviewed, 3 unresolved discussions (waiting on soonum).


LICENSE line 3 at r2 (raw file):

BSD 3-Clause Clear License

Copyright © 2025 ZAMA.

will need a rebase for license year

Base automatically changed from dt/chore/fix_lints to main April 15, 2026 12:50
soonum added 2 commits April 15, 2026 14:55
Latest major version of actions/github (v9.0.0), switch from CommonJS to
ESM. The code changes in this commit simply does the migration in this
two javascript flavors.
@soonum soonum force-pushed the dt/refactor/use_esm branch from dd190d2 to 74b261e Compare April 15, 2026 12:56
Copy link
Copy Markdown
Contributor Author

@soonum soonum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soonum made 3 comments and resolved 1 discussion.
Reviewable status: 9 of 22 files reviewed, 2 unresolved discussions (waiting on IceTDrinker).


.github/linters/eslint.config.mjs line 2 at r1 (raw file):

Previously, IceTDrinker wrote…

not sure I understand that one ?

This is a problem related to import that exists in v9 of ESlint. The rule associated to this lint has been removed in v10. So we can safely disable it as long as we have v9 as dependency.


.github/linters/eslint.config.mjs line 13 at r1 (raw file):

Previously, IceTDrinker wrote…

no idea if this config is correct

That's the recommended way of setting up things from both ESLint ans super-linter documentation.


LICENSE line 3 at r2 (raw file):

Previously, IceTDrinker wrote…

will need a rebase for license year

Done

@soonum soonum requested a review from IceTDrinker April 15, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants