Skip to content

chore(ci): fix various findings from linter#75

Merged
soonum merged 6 commits intomainfrom
dt/chore/fix_lints
Apr 15, 2026
Merged

chore(ci): fix various findings from linter#75
soonum merged 6 commits intomainfrom
dt/chore/fix_lints

Conversation

@soonum
Copy link
Copy Markdown
Contributor

@soonum soonum commented Apr 9, 2026

This also change the license to BSD 3-Clause Clear to reflect what's being used at Zama.

Note that the Zizmor linter will be failling for now to the addition of a rule that would be too complicated to apply in our case. Luckily, this rule won't be matched by default on the next version of Zimor. By then the linter should turn back to green.

Issues regarding Javascript and dependencies would be fixed in a follow-up PR.


This change is Reviewable

@soonum soonum requested a review from IceTDrinker April 9, 2026 08:15
@soonum soonum self-assigned this Apr 9, 2026
@soonum soonum marked this pull request as draft April 9, 2026 08:17
@soonum soonum force-pushed the dt/chore/fix_lints branch 2 times, most recently from 8c79c89 to 04c6612 Compare April 9, 2026 08:29
@soonum
Copy link
Copy Markdown
Contributor Author

soonum commented Apr 14, 2026

Rest of the linting errors are fixed in #76

Copy link
Copy Markdown
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License year needs updating

@IceTDrinker reviewed 13 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on soonum).


LICENSE line 3 at r1 (raw file):

BSD 3-Clause Clear License

Copyright © 2025 ZAMA.

2025 -> 2026

@soonum soonum force-pushed the dt/chore/fix_lints branch from 04c6612 to fc4080d Compare April 15, 2026 09:26
@soonum soonum requested a review from IceTDrinker April 15, 2026 09:26
Copy link
Copy Markdown
Contributor Author

@soonum soonum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@soonum made 1 comment and resolved 1 discussion.
Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on IceTDrinker).

Copy link
Copy Markdown
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lesgo

@soonum soonum marked this pull request as ready for review April 15, 2026 12:50
@soonum soonum merged commit a10ca70 into main Apr 15, 2026
15 of 19 checks passed
@soonum soonum deleted the dt/chore/fix_lints branch April 15, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants