Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 55.38% 54.47% -0.92%
==========================================
Files 279 288 +9
Lines 26960 28043 +1083
==========================================
+ Hits 14933 15276 +343
- Misses 10965 11691 +726
- Partials 1062 1076 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. |
rimangan
previously approved these changes
Apr 20, 2022
RavenYL
reviewed
Apr 24, 2022
RavenYL
approved these changes
Apr 25, 2022
RavenYL
requested changes
Apr 25, 2022
Contributor
RavenYL
left a comment
RavenYL
left a comment
There was a problem hiding this comment.
If following strand could be written as a option that would be great!
cshoben
reviewed
Aug 7, 2022
Contributor
cshoben
left a comment
cshoben
left a comment
There was a problem hiding this comment.
Not sure if we are waiting to review this one, but happy to approve when it's time.
| ans = fasta.RemoveGaps(ans) | ||
| ans = extractMultiHelper(records, b.ChromStart, b.ChromEnd, s.RemoveGaps, b.Strand == bed.Negative) | ||
| if b.FieldsInitialized >= 4 { | ||
| fasta.Write(fmt.Sprintf("%s.fa", b.Name), ans) |
Contributor
There was a problem hiding this comment.
Can you help me understand why we would name the output file differently if the fields initialized are less than or equal to 4? I'm assuming it would be to not lose information, but then we do not seem to include the chrom start end anymore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some minor functionality to the code. It will now reverse complement a sequence if the bed file denotes the negative strand