Skip to content

fix(build): add C++17 and MSVC warning suppressions #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CraftSpider merged 1 commit into from
Apr 18, 2026
Merged

fix(build): add C++17 and MSVC warning suppressions #1354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/engine_xetex/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,13 @@ fn main() {
if target.contains("-msvc") {
c_cfg.flag("/EHsc");
cxx_cfg.flag("/EHsc");
cxx_cfg.flag("/std:c++17");
// Disable noisy warnings that are enabled by -Wall
cxx_cfg.flag("/wd4514"); // unreferenced inline function has been removed
cxx_cfg.flag("/wd5045"); // Spectre mitigation insertion (informational)
cxx_cfg.flag("/wd4820"); // padding added after data member
cxx_cfg.flag("/wd4244"); // conversion from 'type1' to 'type2', possible loss of data
cxx_cfg.flag("/wd4365"); // conversion from 'type1' to 'type2', signed/unsigned mismatch
}

// OK, back to generic build rules.
Expand Down
Loading