test(e2e): fix post-refetch assertions to use toContainText() with retry#1376
Merged
steilerDev merged 2 commits intobetafrom Apr 28, 2026
Merged
test(e2e): fix post-refetch assertions to use toContainText() with retry#1376steilerDev merged 2 commits intobetafrom
steilerDev merged 2 commits intobetafrom
Conversation
Replace textContent() + sync expect() with expect(locator).toContainText() in Scenarios 1-5 of the Filter-aware summary rows test block. The old pattern reads the DOM immediately after waitForResponse resolves, before React has committed the state update — causing intermittent CI failures when the re-render is slightly delayed. toContainText() retries with the configured expect timeout (7s for desktop), ensuring the assertion runs against the updated DOM. Co-Authored-By: Claude e2e-test-engineer (Sonnet 4.6) <noreply@anthropic.com>
…el change Fix #1369 (PR #1374) changed the DocumentBrowser "Hide linked documents" checkbox label to "Hide already-linked documents". The duplicate-link scenario test used the old regex /hide linked/i which no longer matches, causing the test to timeout on Desktop, Tablet, and Mobile (all three @Responsive projects = shards 3, 9, 14). Update the locator regex to /hide already-linked documents/i. The checkbox now defaults to unchecked (hideLinked=false after #1369), so the uncheck() call is a no-op — kept for symmetry. Co-Authored-By: Claude e2e-test-engineer (Sonnet 4.6) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.4.2-beta.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 2.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
textContent()+ syncexpect().toContain()withexpect(locator).toContainText()in Scenarios 1–5 of theFilter-aware summary rowsdescribe block inbudget-source-filter.spec.tswaitForResponseresolves, before React has committed thesetBreakdown()state update — causing intermittent CI failures under loadtoContainText()retries with the configured expect timeout (7s desktop / 10s tablet/mobile) so the assertion waits for the DOM to reflect the new valueTest plan
Co-Authored-By: Claude e2e-test-engineer (Sonnet 4.6) noreply@anthropic.com
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com