chore: update implementation checklist with E2E assertion and locator lessons#1379
Merged
steilerDev merged 1 commit intobetafrom Apr 28, 2026
Merged
chore: update implementation checklist with E2E assertion and locator lessons#1379steilerDev merged 1 commit intobetafrom
steilerDev merged 1 commit intobetafrom
Conversation
… lessons Two patterns added from v2.4.2 release fix loop: - Post-mutation assertions must use Playwright retrying assertions (toContainText) not textContent() + sync expect — waitForResponse resolves before React re-renders - Text regex locators must be updated when UI labels change; prefer data-testid or broad patterns resilient to minor rewording Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.4.3-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 tasks
Contributor
|
🎉 This PR is included in version 2.4.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two E2E testing patterns to the implementation checklist, learned from the v2.4.2 release fix loop:
toContainText(),toHaveText()) rather thantextContent()+ syncexpect()after data mutations.waitForResponse()resolves at network level before React re-renders the DOM.data-testidor broad regex patterns resilient to minor rewording.These patterns caused shard failures in the v2.4.2 promotion PR (PR #1376 fixed them).
Test plan