Do not propose to refactor when no variant constructor is used#16867
Merged
Jarcho merged 1 commit intorust-lang:masterfrom Apr 16, 2026
Merged
Do not propose to refactor when no variant constructor is used#16867Jarcho merged 1 commit intorust-lang:masterfrom
Jarcho merged 1 commit intorust-lang:masterfrom
Conversation
If all the ways to "leave" the closure is through a divergent statement other than `return` (not detected as a potential return value by the visitor), do not trigger the lint.
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Jarcho
approved these changes
Apr 16, 2026
rustbot
removed
the
S-waiting-on-review
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If all the ways to "leave" the closure is through a divergent statement other than
return(not detected as a potential return value by the visitor), do not trigger the lint.changelog: [
bind_instead_of_map]: do not propose to rewrite the expression if the only way to leave the closure is through a divergent statement other thanreturnFixes #16861