Skip to content

find_all_ret_expressions: change bool to Result#16797

Open
GrigorenkoPV wants to merge 1 commit intorust-lang:masterfrom
GrigorenkoPV:find_all_ret_expresions
Open

find_all_ret_expressions: change bool to Result#16797
GrigorenkoPV wants to merge 1 commit intorust-lang:masterfrom
GrigorenkoPV:find_all_ret_expresions

Conversation

@GrigorenkoPV
Copy link
Copy Markdown
Contributor

I think the semantics are clearer this way


changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 3, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 3, 2026

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

@GrigorenkoPV GrigorenkoPV force-pushed the find_all_ret_expresions branch from 7423870 to ea789f7 Compare April 3, 2026 11:16
@GrigorenkoPV GrigorenkoPV force-pushed the find_all_ret_expresions branch from ea789f7 to d610e05 Compare April 3, 2026 11:26
@GrigorenkoPV GrigorenkoPV changed the title find_all_ret_expressions: change bool to Result<(), ()> find_all_ret_expressions: change bool to Result Apr 3, 2026
@llogiq
Copy link
Copy Markdown
Contributor

llogiq commented Apr 5, 2026

I don't see any benefit from this. It adds four lines of code, too. So unless you can give me a good reason not to, I would favor closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants