find_all_ret_expressions: change bool to Result#16797
Open
GrigorenkoPV wants to merge 1 commit intorust-lang:masterfrom
Open
find_all_ret_expressions: change bool to Result#16797GrigorenkoPV wants to merge 1 commit intorust-lang:masterfrom
bool to Result#16797GrigorenkoPV wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
7423870 to
ea789f7
Compare
ea789f7 to
d610e05
Compare
bool to Result<(), ()>bool to Result
7 tasks
Contributor
|
I don't see any benefit from this. It adds four lines of code, too. So unless you can give me a good reason not to, I would favor closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the semantics are clearer this way
changelog: none