Always take a shared lock on .cargo-lock#16886
Merged
epage merged 1 commit intorust-lang:masterfrom Apr 14, 2026
Merged
Conversation
This commit changes the behavior to always take a shared lock on `.cargo-lock` to ensure backwards compatiblity with older versions of cargo that do not lock `.cargo-build-lock`. To allow `cargo check` and `cargo build` to continue running concurrently `.cargo-artifact-lock` was added with the original behavior of `.cargo-lock`.
rustbot
added
A-layout
Collaborator
|
r? @ehuss rustbot has assigned @ehuss. Use Why was this reviewer chosen?The reviewer was selected based on:
|
epage
approved these changes
Apr 14, 2026
Contributor
|
Once this is merged, can you do a beta backport? Look to past PRs to see the general structure. |
rustbot
removed
the
S-waiting-on-review
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This PR changes the behavior to always take a shared lock on
.cargo-lockto ensure backwards compatibility with older versions of cargo that do not lock.cargo-build-lock.To allow
cargo checkandcargo buildto continue running concurrently.cargo-artifact-lockwas added with the original behavior of.cargo-lock.We may be able to revert this change after the new build-dir layout is stablized. (#16807)
closes: #16853
How to test and review this PR?
See the test changes