Skip to content

[beta-1.96] Always take a shared lock on .cargo-lock#16887

Merged
epage merged 1 commit intorust-lang:rust-1.96.0from
ranger-ross:beta-backport-96
Apr 15, 2026
Merged

[beta-1.96] Always take a shared lock on .cargo-lock#16887
epage merged 1 commit intorust-lang:rust-1.96.0from
ranger-ross:beta-backport-96

Conversation

@ranger-ross
Copy link
Copy Markdown
Member

Beta backports

To resolve a regression locking compatibility with older versions (see: #16853)

This commit changes the behavior to always take a shared lock on
`.cargo-lock` to ensure backwards compatiblity with older versions of
cargo that do not lock `.cargo-build-lock`.

To allow `cargo check` and `cargo build` to continue running concurrently
`.cargo-artifact-lock` was added with the original behavior of `.cargo-lock`.
@rustbot rustbot added A-layout Area: target output directory layout, naming, and organization S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 15, 2026

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, epage, weihanglo

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 15, 2026

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.96.0. Please double check that you specified the right target!

@epage epage enabled auto-merge April 15, 2026 00:52
@epage epage merged commit 9fb1715 into rust-lang:rust-1.96.0 Apr 15, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2026
rust-bors bot pushed a commit to rust-lang/rust that referenced this pull request Apr 15, 2026
[beta-1.96] Update cargo submodule

1 commits in eb94155a9a60943bd7b1cb04abec42f5d0de6ddc..9fb171546a9db5513062de20df78116ed5ee7668
2026-04-09 13:10:20 +0000 to 2026-04-14 20:13:35 -0500
- [beta-1.96] Always take a shared lock on `.cargo-lock` (rust-lang/cargo#16887)

r? ghost
rust-bors bot pushed a commit to rust-lang/rust that referenced this pull request Apr 15, 2026
[beta-1.96] Update cargo submodule

1 commits in eb94155a9a60943bd7b1cb04abec42f5d0de6ddc..9fb171546a9db5513062de20df78116ed5ee7668
2026-04-09 13:10:20 +0000 to 2026-04-14 20:13:35 -0500
- [beta-1.96] Always take a shared lock on `.cargo-lock` (rust-lang/cargo#16887)

r? ghost
@rustbot rustbot added this to the 1.96.0 milestone Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-layout Area: target output directory layout, naming, and organization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants