Skip to content

tests: Use output from Flash Player in more tests #23463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kjarosh wants to merge 5 commits into
base: master
Choose a base branch
from
Open

tests: Use output from Flash Player in more tests #23463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4cef9c8
tests: Fix from_shumway/acid/acid-clip-2
kjarosh Apr 15, 2026
12633f0
tests: Fix from_shumway/acid/acid-color-2
kjarosh Apr 15, 2026
cbb956b
tests: Fix from_shumway/acid/acid-filter-2
kjarosh Apr 15, 2026
c63a336
tests: Fix from_shumway/acid/acid-morph
kjarosh Apr 15, 2026
b13e0a3
tests: Fix from_shumway/acid/acid-shapes
kjarosh Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified tests/tests/swfs/from_shumway/acid/acid-clip-2/output.expected.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 15 additions & 2 deletions tests/tests/swfs/from_shumway/acid/acid-clip-2/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,21 @@

num_frames = 1

[image_comparisons.output]
[[image_comparisons.output.checks]]
tolerance = 0
max_outliers = 2900

[[image_comparisons.output.checks]]
tolerance = 32
max_outliers = 1300

[[image_comparisons.output.checks]]
tolerance = 64
max_outliers = 300

[[image_comparisons.output.checks]]
tolerance = 110
max_outliers = 0

[player_options]
with_renderer = { optional = false, quality = "low" }
with_renderer = { quality = "high" }
Binary file modified tests/tests/swfs/from_shumway/acid/acid-color-2/output.expected.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 15 additions & 2 deletions tests/tests/swfs/from_shumway/acid/acid-color-2/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,21 @@

num_frames = 1

[image_comparisons.output]
[[image_comparisons.output.checks]]
tolerance = 0
max_outliers = 6000

[[image_comparisons.output.checks]]
tolerance = 32
max_outliers = 1500

[[image_comparisons.output.checks]]
tolerance = 52
max_outliers = 100

[[image_comparisons.output.checks]]
tolerance = 80
max_outliers = 0

[player_options]
with_renderer = { optional = false, quality = "low" }
with_renderer = { quality = "high" }
Binary file modified tests/tests/swfs/from_shumway/acid/acid-filter-2/output.expected.png
View file
Open in desktop
Copy link
Copy Markdown
Collaborator

@evilpie evilpie Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the colors so different? Is this HDR or something like that?

Copy link
Copy Markdown
Member Author

@kjarosh kjarosh Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what way different? Different from what?

Copy link
Copy Markdown
Collaborator

@evilpie evilpie Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The red was much more red before. Color picker says it was #ff0202 and now is #e43a21.

Copy link
Copy Markdown
Member Author

@kjarosh kjarosh Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about that #e43a21? Where are you getting it from? The new image is sRGB and should be #ff0000 and that's what I'm getting when picking color from the new image 🤔

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 8 additions & 3 deletions tests/tests/swfs/from_shumway/acid/acid-filter-2/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,13 @@

num_frames = 1

[image_comparisons.output]
tolerance = 2
[[image_comparisons.output.checks]]
tolerance = 5
max_outliers = 2500

[[image_comparisons.output.checks]]
tolerance = 20
max_outliers = 0

[player_options]
with_renderer = { optional = false, quality = "low" }
with_renderer = { quality = "high" }
Binary file modified tests/tests/swfs/from_shumway/acid/acid-morph/output.expected.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 10 additions & 3 deletions tests/tests/swfs/from_shumway/acid/acid-morph/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,15 @@

num_frames = 30

[image_comparisons.output]
tolerance = 1
# FIXME The box is too thick.

[[image_comparisons.output.checks]]
tolerance = 10
max_outliers = 5600

[[image_comparisons.output.checks]]
tolerance = 64
max_outliers = 2600

[player_options]
with_renderer = { optional = false, quality = "low" }
with_renderer = { quality = "high" }
Binary file modified tests/tests/swfs/from_shumway/acid/acid-shapes/output.expected.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
25 changes: 23 additions & 2 deletions tests/tests/swfs/from_shumway/acid/acid-shapes/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,29 @@

num_frames = 1

[image_comparisons.output]
[[image_comparisons.output.checks]]
tolerance = 3
max_outliers = 113000

[[image_comparisons.output.checks]]
tolerance = 16
max_outliers = 61300

[[image_comparisons.output.checks]]
tolerance = 32
max_outliers = 25600

[[image_comparisons.output.checks]]
tolerance = 64
max_outliers = 5600

[[image_comparisons.output.checks]]
tolerance = 128
max_outliers = 180

[[image_comparisons.output.checks]]
tolerance = 200
max_outliers = 0

[player_options]
with_renderer = { optional = false, quality = "low" }
with_renderer = { quality = "high" }
Loading