Skip to content

tests: Use output from Flash Player in more tests#23463

Open
kjarosh wants to merge 5 commits intoruffle-rs:masterfrom
kjarosh:fix-tests-5
Open

tests: Use output from Flash Player in more tests#23463
kjarosh wants to merge 5 commits intoruffle-rs:masterfrom
kjarosh:fix-tests-5

Conversation

@kjarosh
Copy link
Copy Markdown
Member

@kjarosh kjarosh commented Apr 15, 2026

Fixed tests:

  • from_shumway/acid/acid-clip-2,
  • from_shumway/acid/acid-color-2,
  • from_shumway/acid/acid-filter-2,
  • from_shumway/acid/acid-morph,
  • from_shumway/acid/acid-shapes.

@kjarosh kjarosh added A-tests Area: Tests & Test Framework T-fix Type: Bug fix (in something that's supposed to work already) waiting-on-review Waiting on review from a Ruffle team member labels Apr 15, 2026
kjarosh added 5 commits April 16, 2026 23:31
Use output from Flash Player and high quality.
Use output from Flash Player and high quality.
Use output from Flash Player and high quality.
Use output from Flash Player and high quality.
Use output from Flash Player and high quality.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the colors so different? Is this HDR or something like that?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what way different? Different from what?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The red was much more red before. Color picker says it was #ff0202 and now is #e43a21.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about that #e43a21? Where are you getting it from? The new image is sRGB and should be #ff0000 and that's what I'm getting when picking color from the new image 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Tests & Test Framework T-fix Type: Bug fix (in something that's supposed to work already) waiting-on-review Waiting on review from a Ruffle team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants