fix: restore size.yml workflow and update size-limit config for ESM-only build#7628
fix: restore size.yml workflow and update size-limit config for ESM-only build#7628
Conversation
|
…trypoint Co-authored-by: TylerJDev <26746305+TylerJDev@users.noreply.github.com>
size-limit report 📦
|
|
387249a to
bd55d40
Compare
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/15334 |
|
Integration test results from github/github-ui:
CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures. Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance. |
PR #6425 removed browser bundles and deleted
size.yml, breaking PR bundle size comments. Thesize-limitconfig inpackage.jsonwas also left pointing to the now-nonexistentdist/browser.esm.jsanddist/browser.umd.js.Changelog
New
.github/workflows/size.yml— triggers onpull_request, runsandresz1/size-limit-action@v1withbuild_script: buildto handle the monorepo ESM-only build before measuring. Adds explicitpermissions: pull-requests: writerequired for posting PR comments.Changed
size-limitconfig in rootpackage.jsonto targetpackages/react/dist/index.jsinstead of the deleted browser bundles:Removed
size-limitentries fordist/browser.esm.jsanddist/browser.umd.jsRollout strategy
CI/workflow-only change — no package code or public API affected.
Testing & Reviewing
Verify that after merging, new PRs receive a bundle size comparison comment from
andresz1/size-limit-action. Thesizesjob inci.yml(Job Summary) is unchanged.Merge checklist
Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.