Extract generate_user_id/generate_login_name as standalone functions#147
Extract generate_user_id/generate_login_name as standalone functions#147mauritsvanrees merged 5 commits intomasterfrom
Conversation
Move user ID and login name generation logic from BaseRegistrationForm methods into standalone functions in plone.app.users.utils, enabling reuse from plone.api and plone.restapi without form view dependency. Part of PLIP 4292. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
Red b/c of old meta.toml, #148 will fix it |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@jenkins-plone-org please run jobs |
mauritsvanrees
left a comment
mauritsvanrees
left a comment
There was a problem hiding this comment.
LGTM. One inline comment about a deprecation notice we should add.
Co-authored-by: David Glick <david@glicksoftware.com>
Mark the backwards-compat re-export with a deprecation warning so it can be removed in Plone 7. Consumers should import from plone.app.users.utils instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jensens
force-pushed
the
plip-4292-fix-user-creation
branch
from
e0f8f03 to
76fb2d7
Compare
|
@jenkins-plone-org please run jobs |
|
Thanks! |
4 participants
Part of PLIP 4292.
generate_user_id()andgenerate_login_name()fromBaseRegistrationForminto standalone functions inplone.app.users.utilsplone.apiandplone.restapiwithout form view dependencyDepends on: nothing
Depended on by: plone/plone.api#603 plone/plone.restapi#1993