Use standalone generate_user_id/generate_login_name#2001
Merged
Conversation
Replace register form view instantiation with direct calls to standalone functions from plone.app.users.utils. Includes BBB fallback for older plone.app.users versions. Part of PLIP 4292. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
davisagli
reviewed
Mar 18, 2026
davisagli
requested changes
Mar 18, 2026
Member
davisagli
left a comment
davisagli
left a comment
There was a problem hiding this comment.
Please run make format to fix the isort QA error
davisagli
approved these changes
Mar 20, 2026
Member
Author
|
@jenkins-plone-org please run jobs |
mauritsvanrees
requested changes
Mar 23, 2026
Co-authored-by: Maurits van Rees <maurits@vanrees.org>
Lines 257-258 were missing indentation, causing syntax errors that broke QA (pyupgrade, black, flake8) and coverage CI jobs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
@jenkins-plone-org please run jobs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PLIP 4292.
plone.app.users.utilsinstead of instantiating register form viewplone.app.usersversions (Plone < 6.2)Depends on: plone/plone.app.users#147
📚 Documentation preview 📚: https://plonerestapi--2001.org.readthedocs.build/