Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
May 19, 2025
| paramSchema: ZodSchema | null, | ||
| bodySchema: ZodSchema | null | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| paramSchema: ZodType<any> | null, |
Collaborator
Author
There was a problem hiding this comment.
The default value of the generic param in v3 is any, but in v4 it's unknown, which is better a general practice. We pass in any explicitly to get the old behavior back. It would be nice to fix the code so unknown works, and I might do that, but it's also not worth much. This code is only used in the mock API server and never changes.
david-crespo
commented
May 19, 2025
| state: 'ready', | ||
| }, | ||
| { | ||
| id: '7fc6ca11-452e-d3e4-9e1c-752ff615abea', |
Collaborator
Author
There was a problem hiding this comment.
Turns out this was an invalid UUID, correctly rejected by Zod because of the d in d3e4, which is supposed to be a 4 for UUID v4.
Collaborator
Author
|
Will reopen when we get to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://zod.dev/v4
Was curious how the Zod v4 migration would look, so I tried it and it turned out to be easy enough that I finished it. This will remain a draft for now because we need to upgrade oxide.ts to do automatically what I've done here by hand in the generated code:
z.string().uuid()->z.uuid()z.string().ip()->z.ipv4()or a union of v4 and v6z.record(X)->z.record(z.string(), X)(they got rid of the single-arg shorthand).nullable()before.default(null)sodefaultknows it can takenull