Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
commented
Aug 15, 2025
| // out not to match the real API, which ignores primary: false. | ||
| // https://github.com/oxidecomputer/omicron/blob/61ad056c/nexus/db-queries/src/db/datastore/network_interface.rs?plain=1#L804-L808 | ||
|
|
||
| if (typeof body.primary === 'boolean' && body.primary && !nic.primary) { |
Collaborator
Author
There was a problem hiding this comment.
These tests were failing:
e2ec instance-networking -g 'NIC table' && e2ec instance-networking -g 'Transit IPs'https://zod.dev/v4/changelog?id=defaults-applied-within-optional-fields
The above change means that primary: SafeBoolean.default(false) is putting primary: false on the body, where in v3 it was just left out. That was tripping the "I refuse to unset the primary" logic below. The default comes from here in omicron and has been there for three years.
david-crespo
commented
Aug 15, 2025
| }, | ||
| { | ||
| id: '7fc6ca11-452e-d3e4-9e1c-752ff615abea', | ||
| id: '75832119-7d9b-4e91-a7c6-76b996b69aaa', |
Collaborator
Author
There was a problem hiding this comment.
Turns out this was an invalid UUID, correctly rejected by Zod because of the d in d3e4, which is supposed to be a 4 for UUID v4. Solved this on the last attempt, see #2828 (comment).
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 20, 2025
oxidecomputer/console@777a959...8cc5b25 * [8cc5b253](oxidecomputer/console@8cc5b253) oxidecomputer/console#2891 * [33b2b55c](oxidecomputer/console@33b2b55c) oxidecomputer/console#2890 * [41ed7e3a](oxidecomputer/console@41ed7e3a) oxidecomputer/console#2882 * [887a2cab](oxidecomputer/console@887a2cab) oxidecomputer/console#2870 * [76ca8cff](oxidecomputer/console@76ca8cff) oxidecomputer/console#2879
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 20, 2025
oxidecomputer/console@777a959...8cc5b25 * [8cc5b253](oxidecomputer/console@8cc5b253) oxidecomputer/console#2891 * [33b2b55c](oxidecomputer/console@33b2b55c) oxidecomputer/console#2890 * [41ed7e3a](oxidecomputer/console@41ed7e3a) oxidecomputer/console#2882 * [887a2cab](oxidecomputer/console@887a2cab) oxidecomputer/console#2870 * [76ca8cff](oxidecomputer/console@76ca8cff) oxidecomputer/console#2879
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing it properly this time.
oxidecomputer/oxide.ts#300