spi: correct spi mode selection logic#79
Merged
kwd-doodling merged 1 commit intointel:mainfrom Apr 30, 2026
Merged
Conversation
xiaolusu
requested review from
kwd-doodling,
lifenggitacc and
likongintel
as code owners
likongintel
approved these changes
Apr 22, 2026
kwd-doodling
approved these changes
Apr 29, 2026
Fix by writing each value to its correct register field: cpha -> SCPH (Serial Clock Phase) cpol -> SCPOL (Serial Clock Polarity) This bug only affected SPI Mode 1 (CPOL=0, CPHA=1) and Mode 2 (CPOL=1, CPHA=0), which got silently swapped. Mode 0 and Mode 3 were unaffected as both fields had the same value. Signed-off-by: Xiaolu Sun <xiaolu.sun@intel.com>
kwd-doodling
force-pushed
the
spi_cpol_cpha
branch
from
2d2099c to
ca61536
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix by writing each value to its correct register field: cpha -> SCPH (Serial Clock Phase)
cpol -> SCPOL (Serial Clock Polarity)
This bug only affected SPI Mode 1 (CPOL=0, CPHA=1) and Mode 2 (CPOL=1, CPHA=0), which got silently swapped.
Mode 0 and Mode 3 were unaffected as both fields had the same value.