Skip to content

fix(artifacts): Handle XmlCData in Android manifest parsing #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(artifacts): Handle XmlCData in Android manifest parsing #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/launchpad/artifacts/android/manifest/axml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from typing import Any

from launchpad.parsers.android.binary.android_binary_parser import AndroidBinaryParser
from launchpad.parsers.android.binary.types import XmlAttribute, XmlNode
from launchpad.parsers.android.binary.types import XmlAttribute, XmlCData, XmlNode
from launchpad.utils.logging import get_logger

from ..resources.binary import BinaryResourceTable
Expand All @@ -27,6 +27,15 @@ def parse_xml(self) -> XmlNode | None:

# Convert the parser's XmlNode to our model's XmlNode
def convert_node(node: Any) -> XmlNode: # type: ignore[no-untyped-def]
if isinstance(node, XmlCData):
return XmlNode(
namespace_uri=None,
node_type=node.node_type,
node_name=node.node_name,
attributes=[],
child_nodes=[],
)

attributes: list[XmlAttribute] = []
for attr in node.attributes:
value = attr.value
Expand Down
Loading