fix(artifacts): Handle XmlCData in Android manifest parsing#605
Draft
sentry[bot] wants to merge 1 commit intomainfrom
Draft
fix(artifacts): Handle XmlCData in Android manifest parsing#605sentry[bot] wants to merge 1 commit intomainfrom
sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
📲 Install BuildsAndroid
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an
AttributeError: 'XmlCData' object has no attribute 'namespace_uri'that occurred during Android manifest parsing inlaunchpad.process_message.Root Cause:
The
convert_nodefunction insrc/launchpad/artifacts/android/manifest/axml.pywas designed to processXmlNodeobjects but could receiveXmlCDataobjects as children.XmlCDataobjects, by design, do not possess anamespace_uriattribute, leading to theAttributeErrorwhenconvert_nodeattempted to access it.Solution:
XmlCDatafromlaunchpad.parsers.android.binary.types.convert_nodefunction. If thenodeis an instance ofXmlCData, a minimalXmlNodestub is returned. This prevents theAttributeErroras CDATA sections do not contain relevant manifest data for extraction.Fixes LAUNCHPAD-6N