Skip to content

fix(artifacts): Handle XmlCData in Android manifest parsing#605

Draft
sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/axml-handle-cdata
Draft

fix(artifacts): Handle XmlCData in Android manifest parsing#605
sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/axml-handle-cdata

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry Bot commented Apr 24, 2026

This PR fixes an AttributeError: 'XmlCData' object has no attribute 'namespace_uri' that occurred during Android manifest parsing in launchpad.process_message.

Root Cause:
The convert_node function in src/launchpad/artifacts/android/manifest/axml.py was designed to process XmlNode objects but could receive XmlCData objects as children. XmlCData objects, by design, do not possess a namespace_uri attribute, leading to the AttributeError when convert_node attempted to access it.

Solution:

  1. Imported XmlCData from launchpad.parsers.android.binary.types.
  2. Added a type guard at the beginning of the convert_node function. If the node is an instance of XmlCData, a minimal XmlNode stub is returned. This prevents the AttributeError as CDATA sections do not contain relevant manifest data for extraction.

Fixes LAUNCHPAD-6N

@sentry
Copy link
Copy Markdown
Contributor Author

sentry Bot commented Apr 24, 2026

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Hacker News com.emergetools.hackernews 1.0.2 (13) Release

⚙️ launchpad-test-android Build Distribution Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants