[o365_metrics,checkpoint_harmony_endpoint] Fix upto/Extention typos in user-facing text#18520
Open
MukundaKatta wants to merge 2 commits intoelastic:mainfrom
Open
[o365_metrics,checkpoint_harmony_endpoint] Fix upto/Extention typos in user-facing text#18520MukundaKatta wants to merge 2 commits intoelastic:mainfrom
MukundaKatta wants to merge 2 commits intoelastic:mainfrom
Conversation
…n user-facing text Text Auditor elastic#18497 surfaced two unambiguous typo families that only appear in user-visible help text and field descriptions, no behaviour change required: * 'upto' -> 'up to' in the o365_metrics sync-description help text (4 data streams: groups_activity_group_detail, viva_engage_groups_activity_group_detail, onedrive_usage_account_detail, teams_user_activity_user_detail). * 'Extention' -> 'Extension' in the Check Point Harmony Endpoint zerophishing browser-extension field description and the generated docs/README.md row that mirrors it. Bumps both packages for the Kibana changelog: * o365_metrics 1.1.1 -> 1.1.2 * checkpoint_harmony_endpoint 1.2.0 -> 1.2.1 Link URLs in each changelog entry are placeholders (PR NNN); they will be updated to this PR number once it is assigned. Refs elastic#18497.
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
ReviewersBuildkite won't run for external contributors automatically; you need to add a comment:
NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details. |
andrewkroh
added
Integration:o365_metrics
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #18497.
Picks up the two typo families the Text Auditor workflow flagged. Both are user-visible strings (Kibana help text and field descriptions), no behaviour change required.
Changes
upto→up to(o365_metrics, 4 occurrences)...can take upto 48h or more to be available...→...can take up to 48h or more to be available...packages/o365_metrics/data_stream/groups_activity_group_detail/manifest.ymlpackages/o365_metrics/data_stream/viva_engage_groups_activity_group_detail/manifest.ymlpackages/o365_metrics/data_stream/onedrive_usage_account_detail/manifest.ymlpackages/o365_metrics/data_stream/teams_user_activity_user_detail/manifest.ymlExtention→Extension(checkpoint_harmony_endpoint, 2 occurrences)Browser Extention version→Browser Extension versionpackages/checkpoint_harmony_endpoint/data_stream/zerophishing/fields/fields.ymlpackages/checkpoint_harmony_endpoint/docs/README.mdVersion bumps
Per the repo's release policy, each touched package gets a patch bump with a changelog entry:
o365_metrics:1.1.1→1.1.2(bugfix)checkpoint_harmony_endpoint:1.2.0→1.2.1(bugfix)The
link:fields in the new changelog entries currently point atPR NNN— I'll swap them to this PR's number once GitHub assigns it (or a reviewer is welcome to push that tweak before merging).