Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a possible solution for avoiding massive memory leaks that occur via closures.
These leaks happen for each property built on the
valuesvariable. In other words, for every property of thedefaultsobject, a leaking closure is created.In order to overcome such a behavior, the
destroymethod is introduced on the Options object.Proposed usage:
However, in certain use cases, a developer might find useful to "forget" about the Options object and continue using its
valuesproperty object. In such a situation it would be clumsy to drag the reference to the original Options object in order todestroyit eventually.For such cases, another helper is introduced - the
destroymethodname.Proposed usage:
The PR proposed is backwards-compatible - but one should bare in mind that without calling
destroyon the Options object or thedestroymethodnameon itsvaluesproperty, the resulting memory leaks will remain in massive amounts.