Closed
Conversation
Member
|
Might make more sense to dump the options module completely. |
Member
|
As for the |
Contributor
|
Regarding the Options pullreq, I can accept it, but at first glance it seems unnecessary. When references to an Options instance are released, everything - including the closures - should be gc'd. |
Contributor
|
@andrija-hers could you rebase it with master |
Author
|
@JacksonTian I'll do my best, asap |
Member
|
Is this still needed? We no longer depend on |
Member
|
I'm going to close this as there would be a pretty big amount of work only to rebase against master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a massive refactor that minimizes memory leaks.
There are 2 important notes here:
optionsmodule leaks memory massively)I hope that @einaros will take care of the
optionsrepo so that this PR may be accepted.The code changes are pretty much self explanatory, but I'll just note that almost all the work is based on removing the notorious
var self = thisparadigm, that always leads to memory leaks (via closures that never get collected as garbage).