fix: remove unused setuptools dependency from pyproject.toml#188
fix: remove unused setuptools dependency from pyproject.toml#188shenxianpeng merged 2 commits intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughRemoved the "setuptools>=45.0.0" dependency constraint from the project dependencies in pyproject.toml. No other build system configuration or remaining dependencies were altered. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 95.41% 95.41%
=======================================
Files 4 4
Lines 109 109
=======================================
Hits 104 104
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
npm warn exec The following package was not found and will be installed: cspell-cli@9.7.0
1/1 730.21ms X
:1:20 - Unknown word (setuptools)
:1:47 - Unknown word (pyproject)
CSpell: Files checked: 1, Issues found: 2 in 1 file.
Error: Process completed with exit code 1.It's a weird to see a failed. but actually, the unknown words in the cspell.config.yml. https://github.com/cpp-linter/cpp-linter-hooks/actions/runs/23263124309/job/67637095130 Any throughs? @2bndy5 |
Merging this PR will improve performance by 40.31%
Performance Changes
Comparing Footnotes
|
ebb9887 to
21f6e15
Compare
|



Summary by CodeRabbit