Skip to content

[fix][cp] refactor: Remove unused SelectiveColumnReaderFactory #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WangGuangxin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[fix][cp] refactor: Remove unused SelectiveColumnReaderFactory #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions bolt/dwio/dwrf/reader/SelectiveDwrfReader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,32 +69,4 @@ class SelectiveDwrfReader {
}
};

class SelectiveColumnReaderFactory : public ColumnReaderFactory {
public:
explicit SelectiveColumnReaderFactory(
std::shared_ptr<common::ScanSpec> scanSpec)
: scanSpec_(scanSpec) {}

std::unique_ptr<dwio::common::SelectiveColumnReader> buildSelective(
const std::shared_ptr<const dwio::common::TypeWithId>& requestedType,
const std::shared_ptr<const dwio::common::TypeWithId>& fileType,
StripeStreams& stripe,
const StreamLabels& streamLabels,
dwio::common::ColumnReaderStatistics& stats,
FlatMapContext flatMapContext = {}) {
auto params =
DwrfParams(stripe, streamLabels, stats, std::move(flatMapContext));
auto reader = SelectiveDwrfReader::build(
dwio::common::ColumnReaderOptions{},
requestedType,
fileType,
params,
*scanSpec_);
reader->setIsTopLevel();
return reader;
}

private:
std::shared_ptr<common::ScanSpec> const scanSpec_;
};
} // namespace bytedance::bolt::dwrf
Loading