Skip to content

[fix][cp] refactor: Remove unused SelectiveColumnReaderFactory#463

Open
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
WangGuangxin:cp_12842
Open

[fix][cp] refactor: Remove unused SelectiveColumnReaderFactory#463
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
WangGuangxin:cp_12842

Conversation

@WangGuangxin
Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #191

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Describe your changes in detail.
For complex logic, explain the "Why" and "How".

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Remove unused SelectiveColumnReaderFactory

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

@WangGuangxin WangGuangxin force-pushed the cp_12842 branch 3 times, most recently from f12e77a to 52e711f Compare April 2, 2026 02:25
Summary: Pull Request resolved: facebookincubator/velox#12842

Reviewed By: xiaoxmeng

Differential Revision: D72180145

Pulled By: bikramSingh91

fbshipit-source-id: 1e5c32c0bc227a208e36b7ca14e65b154364c776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants