Conversation
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/c5a423e6-fdec-4d0e-8f0b-7330cee6f36f
There was a problem hiding this comment.
Pull request overview
This PR tightens a set of edge cases across UI components on the 1.0.0 branch, focusing on pagination validity, animation-aligned overlay teardown, disconnect safety, and a small markup fix.
Changes:
- Clamp rendered pagination
pageto a valid range to keep current-page rendering stable whenpageis out of bounds. - Introduce/reuse a shared
getAnimationTimeoutMs()utility and adopt it for close/teardown timing in overlay-like components; add timer cleanup on disconnect and tests for these cases. - Improve disconnect safety for tooltip deferred listener setup; remove redundant select sync; fix malformed textarea closing tag; refactor accordion to use the shared animation-timeout helper.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/tabs-tooltip.test.ts | Adds regression test for tooltip disconnect before queued microtask runs. |
| tests/slider-pagination.test.ts | Adds regression test for pagination rendering when page is out of range. |
| tests/overlay-components.test.ts | Adds tests ensuring dialog/drawer close timers don’t fire after disconnect. |
| tests/dropdown-menu.test.ts | Adds test ensuring dropdown-menu close timer doesn’t fire after disconnect. |
| src/utils/dom.ts | Adds shared getAnimationTimeoutMs() helper for computed animation duration/delay. |
| src/components/tooltip/BqTooltip.ts | Guards microtask work with isConnected to avoid stale listener attachment. |
| src/components/textarea/BqTextarea.ts | Fixes malformed <textarea> closing tag in rendered markup. |
| src/components/select/BqSelect.ts | Removes redundant _syncValue call now that option sync schedules reconciliation. |
| src/components/pagination/BqPagination.ts | Clamps rendered page value to [1, total] range. |
| src/components/dropdown-menu/BqDropdownMenu.ts | Uses computed animation timeout for close and clears pending close timer on disconnect. |
| src/components/drawer/BqDrawer.ts | Uses computed animation timeout for close and clears pending close timer on disconnect. |
| src/components/dialog/BqDialog.ts | Uses computed animation timeout for close and clears pending close timer on disconnect. |
| src/components/accordion/BqAccordion.ts | Switches accordion close fallback timing to shared getAnimationTimeoutMs(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/4fc6490e-33d3-41ae-b7c5-f770d1b456ae
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/4fc6490e-33d3-41ae-b7c5-f770d1b456ae
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/4fc6490e-33d3-41ae-b7c5-f770d1b456ae
Applied the disconnect cleanup follow-up in |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/c5806ac5-914b-4ba5-af38-b97bca44f7df
Applied in |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/632cae1e-162b-4168-ae82-7c2a4e7e2276
Applied in |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/50f1c1d0-7fe3-49f3-9dd3-cb1614d65271
Applied in |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
getAnimationTimeoutMs()returning non-fallback timeouts whenanimation-nameisnonedev, thencopilot/sub-pr-11if needed, to confirm whether there are relevant CI failuresanimation-name: nonealways uses the fallback timeout while named0msanimations still return0✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.