Conversation
- Added accessibility features to `bq-table`, including keyboard navigation for sortable columns and aria attributes for better screen reader support. - Updated `bq-tooltip` to automatically link trigger elements with `aria-describedby` for improved accessibility. - Enhanced `bq-progress` to include localized aria-labels and value text for better screen reader support. - Improved `bq-select` to handle dynamic options and maintain accessibility with proper aria attributes. - Added tests for accessibility features in `bq-tooltip`, `bq-select`, and `bq-progress`. - Updated documentation for `bq-table` and `bq-tooltip` to reflect new accessibility features.
…updates - BqCard: Added support for empty header and footer slots, improved header rendering logic. - BqDivider: Introduced vertical label support and improved styling for vertical orientation. - BqInput: Enhanced password visibility toggle logic, added aria-required attribute for required inputs. - BqRadio: Added required prop and visual indication for required fields. - BqSegmentedControl: Improved button synchronization and accessibility attributes. - BqSelect: Added aria-required attribute for required selects. - BqSkeleton: Implemented dimension sanitization to prevent unsafe styles. - BqStatCard: Improved rendering logic and added visual feedback for trends. - BqTable: Added accessible caption support and improved header attributes. - BqTabs: Enhanced tab panel accessibility with proper roles and attributes. - BqTextarea: Improved rendering logic and added aria-required attribute. - Stories: Updated stories for Divider, Radio, Table with new props and examples. - Tests: Added tests for new features and improved existing tests for overlay components.
- Updated drawer.md to improve property, event, slot, and CSS parts formatting; added accessibility section. - Added accessibility details to radio.md and switch.md. - Removed redundant CSS parts section from table.md. - Enhanced tabs.md with accessibility information and improved formatting. - Updated toast.md to include accessibility considerations. - Improved tooltip component by clearing pending show-delay timer in BqTooltip.ts. - Refined accordion, breadcrumbs, checkbox, chip, dialog, drawer, input, segmented control, select, slider, switch, tabs, textarea, and toast stories for better organization and clarity. - Added new stories for various states and configurations across components, including accessibility features and visual variations.
- BqSpinner: Adjusted styles for better visual consistency and accessibility. - BqTable: Added sort labels for better screen reader support. - BqTabs: Improved panel ID generation and aria attributes for better accessibility. - i18n: Added default label for segmented control in English locale. - Dialog stories: Refactored to use a reusable render function for better maintainability. - Drawer stories: Implemented a reusable render function for drawer component stories. - Dropdown Menu: Introduced new stories for dropdown menus with links and disabled states. - Toast: Updated non-dismissible toast to use boolean attribute syntax. - Tooltip: Fixed button element in tooltip story for better semantics. - Tests: Added tests for avatar rendering with CJK names and multi-word non-Latin names. - Tests: Improved dropdown menu tests for better readability and reliability. - Tests: Enhanced segmented control tests to verify localized default labels. - Tests: Added tests for tab buttons linking to generated panels and managing focus.
There was a problem hiding this comment.
Pull request overview
This PR prepares the library for a 1.0.0 release by updating component behavior and accessibility semantics, expanding/standardizing component documentation and Storybook examples, adding/expanding test coverage, and updating CI tooling versions.
Changes:
- Bumps package version to
1.0.0and updates dev tooling dependencies/lockfile. - Improves accessibility/runtime behavior across multiple components (Tabs, Tooltip, Select, Progress, Slider, Accordion, Pagination, etc.) and adds/updates corresponding tests.
- Standardizes/expands component docs and Storybook stories, and updates GitHub Actions Bun version.
Reviewed changes
Copilot reviewed 73 out of 74 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/tabs-tooltip.test.ts | Adds ARIA linkage tests for Tabs/Tooltip |
| tests/slider-pagination.test.ts | Adds aria-valuetext + ellipsis a11y test |
| tests/select.test.ts | New tests for select value sync |
| tests/segmented-control.test.ts | Adds locale fallback label test |
| tests/progress.test.ts | New tests for progress ARIA + clamping |
| tests/overlay-components.test.ts | Adds skeleton injection test; formatting updates |
| tests/empty-state-spinner.test.ts | New tests for empty-state/spinner rendering |
| tests/dropdown-menu.test.ts | Adjusts timing waits and formatting |
| tests/badge.test.ts | Adds pill styling test |
| tests/avatar.test.ts | Adds non‑Latin initials/grapheme tests |
| tests/accordion-enhancements.test.ts | Updates tests for new accordion animation approach |
| stories/tooltip.stories.ts | Uses native button trigger; formatting |
| stories/toast.stories.ts | Formatting + adds NonDismissible story |
| stories/textarea.stories.ts | Formatting + counter/readonly stories |
| stories/tabs.stories.ts | Adds disabled/many tabs stories |
| stories/table.stories.ts | Adds caption/sort args and stories |
| stories/switch.stories.ts | Adds AllSizes story |
| stories/slider.stories.ts | Adds custom range + no label stories |
| stories/select.stories.ts | Adds value/hint/optgroup/required stories |
| stories/segmented-control.stories.ts | Adds disabled option story |
| stories/radio.stories.ts | Adds required + hint args/stories |
| stories/input.stories.ts | Adds counter/readonly stories |
| stories/dropdown-menu.stories.ts | New dropdown menu stories |
| stories/drawer.stories.ts | Reworks to interactive render function; adds variants |
| stories/divider.stories.ts | Adds vertical labeled divider story |
| stories/dialog.stories.ts | Reworks to interactive render function; adds sizes |
| stories/chip.stories.ts | Adds size/variant/disabled examples |
| stories/checkbox.stories.ts | Adds indeterminate story |
| stories/breadcrumbs.stories.ts | Adds separator control + variants |
| stories/accordion.stories.ts | Adds disabled/flush stories + formatting |
| src/i18n/en.ts | Adds progress + segmentedControl strings |
| src/components/tooltip/BqTooltip.ts | Adds uid + aria-describedby linkage/cleanup |
| src/components/textarea/BqTextarea.ts | Adds aria-required + footer formatting (but see comment) |
| src/components/tabs/BqTabs.ts | Links tabs↔panels via id/aria attrs; panel tabbability |
| src/components/table/BqTable.ts | Adds caption prop + improves sortable header UX |
| src/components/stat-card/BqStatCard.ts | Minor style/render formatting adjustments |
| src/components/spinner/BqSpinner.ts | Improves spinner styling + a11y label rendering |
| src/components/slider/BqSlider.ts | Avoids rerender on drag; adds aria-valuetext |
| src/components/skeleton/BqSkeleton.ts | Sanitizes width/height to prevent CSS injection |
| src/components/select/BqSelect.ts | Serializes options + syncs host/native/proxy values |
| src/components/segmented-control/BqSegmentedControl.ts | Adds localized default aria-label fallback |
| src/components/radio/BqRadio.ts | Adds required prop + required mark styling |
| src/components/progress/BqProgress.ts | Adds i18n label fallback, indeterminate semantics, clamping |
| src/components/pagination/BqPagination.ts | A11y for ellipsis + page button aria-labels |
| src/components/input/BqInput.ts | Adds aria-required + formatting tweaks |
| src/components/dropdown-menu/BqDropdownMenu.ts | Adds close animation state (data-closing) + reduced motion |
| src/components/drawer/BqDrawer.ts | Adds close animation state (data-closing) + reduced motion |
| src/components/divider/BqDivider.ts | Improves vertical label layout + formatting |
| src/components/dialog/BqDialog.ts | Adds close animation state (data-closing) + reduced motion |
| src/components/chip/BqChip.ts | Adds keyboard handling for remove button |
| src/components/checkbox/BqCheckbox.ts | Uses logical padding for RTL friendliness |
| src/components/card/BqCard.ts | Allows title + header slot together; hides empty header |
| src/components/avatar/BqAvatar.ts | Grapheme-aware initials + improved status semantics |
| src/components/accordion/BqAccordion.ts | Switches to CSS grid animation + closing state |
| package.json | Version bump to 1.0.0 + dependency updates |
| bun.lock | Lockfile updates for dependency bumps |
| docs/components/tooltip.md | Adds aria-describedby note |
| docs/components/toast.md | Table formatting + adds accessibility section |
| docs/components/tabs.md | Table formatting + adds accessibility section |
| docs/components/table.md | Adds caption docs + accessibility notes |
| docs/components/switch.md | Adds accessibility section |
| docs/components/skeleton.md | Clarifies safe dimension handling |
| docs/components/select.md | Adds hint/form guidance + preselected example |
| docs/components/segmented-control.md | Formatting + documents fallback label behavior |
| docs/components/radio.md | Adds required docs + accessibility section |
| docs/components/progress.md | Updates accessibility behavior description |
| docs/components/drawer.md | Formatting + adds accessibility section |
| docs/components/divider.md | Notes vertical labeled divider behavior |
| docs/components/dialog.md | Formatting + adds accessibility section |
| docs/components/card.md | Adds combined title/header guidance + accessibility |
| docs/components/badge.md | Adds accessibility guidance |
| docs/components/alert.md | Formatting + adds accessibility guidance |
| .github/workflows/test.yml | Updates Bun version + YAML quoting |
| .github/workflows/npm-publish.yml | Updates Bun version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/e4630707-5db7-4123-9766-51140bcfcaad
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/e4630707-5db7-4123-9766-51140bcfcaad
Address review follow-ups for slider and tabs accessibility semantics
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 73 out of 74 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
src/components/tooltip/BqTooltip.ts:78
show()overwritestimerwithout clearing any existing timeout first. Ifshow()is triggered multiple times beforehide(), earlier timeouts can still fire after the tooltip should be hidden, causing visible state to flip unexpectedly. Clear any existingtimerbefore scheduling a new one, and consider settingtimer = nullafter clearing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ing and improve tests for accessibility and behavior
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 73 out of 74 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
6 tasks
Contributor
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/c5a423e6-fdec-4d0e-8f0b-7330cee6f36f
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/4fc6490e-33d3-41ae-b7c5-f770d1b456ae
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/4fc6490e-33d3-41ae-b7c5-f770d1b456ae
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/4fc6490e-33d3-41ae-b7c5-f770d1b456ae
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/c5806ac5-914b-4ba5-af38-b97bca44f7df
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/632cae1e-162b-4168-ae82-7c2a4e7e2276
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/50f1c1d0-7fe3-49f3-9dd3-cb1614d65271
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 75 out of 76 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates documentation for several UI components to improve accessibility guidance, usage examples, and formatting consistency. It also upgrades the Bun version used in GitHub Actions workflows from 1.3.7 to 1.3.11.
Documentation Improvements:
bq-alert,bq-badge,bq-card,bq-dialog,bq-drawer,bq-progress,bq-radio, andbq-segmented-control, detailing ARIA roles, keyboard navigation, and screen reader support. [1] [2] [3] [4] [5] [6] [7] [8]bq-select, required radios forbq-radio, and combining title and header slot forbq-card. [1] [2] [3]bq-selectnow mentions hint text and form participation. [1] [2] [3]Workflow Updates:
1.3.7to1.3.11in all GitHub Actions workflows (npm-publish.yml,test.yml) to ensure builds and tests use the latest compatible runtime. [1] [2] [3] [4]These changes collectively improve the accessibility, clarity, and maintainability of the documentation and ensure CI workflows use up-to-date tooling.