Skip to content

fix(storyboards): advance hardcoded 2026-04-01 past dates to 2027-06-01 #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bokelley wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(storyboards): advance hardcoded 2026-04-01 past dates to 2027-06-01 #3285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/fix-storyboard-past-start-time.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
---

Advance hardcoded 2026-04-01 / 2026-04-07 dates in compliance storyboards to 2027-06-01.

The original dates are now in the past. Conformant seller agents that enforce INVALID_REQUEST
for past start_time correctly rejected storyboard requests before reaching the intended behavior
(e.g. GOVERNANCE_DENIED), causing false failures. No DSL dynamic-date mechanism exists yet;
bumping to a far-future date restores correctness until a $generate:future_date expression type
can be introduced. Test-vector JCS hashes and sales-social event_time (historical event data) left unchanged.
2 changes: 1 addition & 1 deletion static/compliance/source/protocols/governance/index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ phases:
brand:
domain: "acmeoutdoor.example"
governance_context: "gov_ctx_acme_q2_approved"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "sports_ctv_q2"
Expand Down
2 changes: 1 addition & 1 deletion static/compliance/source/protocols/media-buy/index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ phases:
brand:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "sports_preroll_q2"
Expand Down
2 changes: 1 addition & 1 deletion static/compliance/source/protocols/media-buy/scenarios/delivery_reporting.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ phases:
brand:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "outdoor_display_q2"
Expand Down
4 changes: 2 additions & 2 deletions static/compliance/source/protocols/media-buy/scenarios/governance_approved.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ phases:
currency: "USD"
reallocation_threshold: 100000
flight:
start: "2026-04-01T00:00:00Z"
start: "2027-06-01T00:00:00Z"
end: "2026-06-30T23:59:59Z"
countries: ["US", "CA"]
validations:
Expand Down Expand Up @@ -196,7 +196,7 @@ phases:
brand:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "outdoor_display_q2"
Expand Down
4 changes: 2 additions & 2 deletions static/compliance/source/protocols/media-buy/scenarios/governance_conditions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ phases:
currency: "USD"
reallocation_threshold: 100000
flight:
start: "2026-04-01T00:00:00Z"
start: "2027-06-01T00:00:00Z"
end: "2026-06-30T23:59:59Z"
countries: ["US", "CA"]
custom_policies:
Expand Down Expand Up @@ -183,7 +183,7 @@ phases:
brand:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "outdoor_ctv_q2"
Expand Down
4 changes: 2 additions & 2 deletions static/compliance/source/protocols/media-buy/scenarios/governance_denied.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ phases:
currency: "USD"
reallocation_threshold: 5000
flight:
start: "2026-04-01T00:00:00Z"
start: "2027-06-01T00:00:00Z"
end: "2026-06-30T23:59:59Z"
countries: ["US"]
validations:
Expand Down Expand Up @@ -174,7 +174,7 @@ phases:
brand:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "outdoor_display_q2"
Expand Down
6 changes: 3 additions & 3 deletions static/compliance/source/protocols/media-buy/scenarios/governance_denied_recovery.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ phases:
currency: "USD"
reallocation_threshold: 5000
flight:
start: "2026-04-01T00:00:00Z"
start: "2027-06-01T00:00:00Z"
end: "2026-06-30T23:59:59Z"
countries: ["US"]
validations:
Expand Down Expand Up @@ -181,7 +181,7 @@ phases:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"
idempotency_key: "gov-recovery-initial-denied-v1"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "$context.product_id"
Expand Down Expand Up @@ -226,7 +226,7 @@ phases:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"
idempotency_key: "gov-recovery-retry-approved-v1"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "$context.product_id"
Expand Down
2 changes: 1 addition & 1 deletion static/compliance/source/protocols/media-buy/scenarios/proposal_finalize.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ phases:
total_budget:
amount: 50000
currency: "USD"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"

idempotency_key: "$generate:uuid_v4#media_buy_seller_proposal_finalize_accept_proposal_create_media_buy"
Expand Down
2 changes: 1 addition & 1 deletion static/compliance/source/specialisms/brand-rights/index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ phases:
uses:
- "likeness"
- "commercial"
start_date: "2026-04-01"
start_date: "2027-06-01"
end_date: "2026-06-30"
revocation_webhook:
url: "https://pinnacle-agency.example/webhooks/revocation"
Expand Down
4 changes: 2 additions & 2 deletions static/compliance/source/specialisms/brand-rights/scenarios/governance_denied.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ phases:
currency: "USD"
reallocation_threshold: 25
flight:
start: "2026-04-01T00:00:00Z"
start: "2027-06-01T00:00:00Z"
end: "2026-06-30T23:59:59Z"
countries: ["US"]
idempotency_key: "$generate:uuid_v4#brand_rights_governance_denied_governance_plan_setup_sync_plans"
Expand Down Expand Up @@ -182,7 +182,7 @@ phases:
uses:
- "likeness"
- "commercial"
start_date: "2026-04-01"
start_date: "2027-06-01"
end_date: "2026-06-30"
revocation_webhook:
url: "https://pinnacle-agency.example/webhooks/revocation"
Expand Down
2 changes: 1 addition & 1 deletion static/compliance/source/specialisms/creative-generative/generative-seller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ phases:
brand:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "outdoor_display_q2"
Expand Down
4 changes: 2 additions & 2 deletions static/compliance/source/specialisms/governance-delivery-monitor/index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ fixtures:
total: 40000
currency: "USD"
flight:
start: "2026-04-01T00:00:00Z"
start: "2027-06-01T00:00:00Z"
end: "2026-06-30T23:59:59Z"

phases:
Expand Down Expand Up @@ -271,7 +271,7 @@ phases:
brand:
domain: "acmeoutdoor.example"
governance_context: "gov_ctx_acme_delivery_approved"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "sports_ctv_q2"
Expand Down
2 changes: 1 addition & 1 deletion static/compliance/source/specialisms/governance-spend-authority/index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ phases:
brand:
domain: "acmeoutdoor.example"
governance_context: "gov_ctx_acme_conditional_approved"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "sports_ctv_q2"
Expand Down
4 changes: 2 additions & 2 deletions static/compliance/source/specialisms/sales-catalog-driven/index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ phases:
brand:
domain: "amsterdam-steakhouse.example"
operator: "pinnacle-agency.example"
start_time: "2026-04-07T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "local_display_dynamic"
Expand Down Expand Up @@ -713,7 +713,7 @@ phases:
operator: "pinnacle-agency.example"
media_buy_id: "$context.media_buy_id"
measurement_period:
start: "2026-04-07T00:00:00Z"
start: "2027-06-01T00:00:00Z"
end: "2026-04-14T23:59:59Z"
performance_index: 1.4
metric_type: "conversion_rate"
Expand Down
2 changes: 1 addition & 1 deletion static/compliance/source/specialisms/sales-guaranteed/index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ phases:
brand:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "sports_preroll_q2_guaranteed"
Expand Down
2 changes: 1 addition & 1 deletion static/compliance/source/specialisms/sales-non-guaranteed/index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ phases:
brand:
domain: "acmeoutdoor.example"
operator: "pinnacle-agency.example"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"
packages:
- product_id: "sports_display_auction"
Expand Down
2 changes: 1 addition & 1 deletion static/compliance/source/specialisms/sales-proposal-mode/index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ phases:
total_budget:
amount: 50000
currency: "USD"
start_time: "2026-04-01T00:00:00Z"
start_time: "2027-06-01T00:00:00Z"
end_time: "2026-06-30T23:59:59Z"

idempotency_key: "$generate:uuid_v4#sales_proposal_mode_accept_proposal_create_media_buy"
Expand Down
2 changes: 1 addition & 1 deletion static/compliance/source/specialisms/signal-marketplace/scenarios/governance_denied.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ phases:
currency: "USD"
reallocation_threshold: 50
flight:
start: "2026-04-01T00:00:00Z"
start: "2027-06-01T00:00:00Z"
end: "2026-06-30T23:59:59Z"
countries: ["US"]
idempotency_key: "$generate:uuid_v4#signal_marketplace_governance_denied_governance_plan_setup_sync_plans"
Expand Down
6 changes: 3 additions & 3 deletions static/compliance/source/universal/deterministic-testing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ phases:
operator: 'pinnacle-agency.example'
brand:
domain: 'acmeoutdoor.example'
start_time: '2026-04-01T00:00:00Z'
start_time: '2027-06-01T00:00:00Z'
end_time: '2026-06-30T23:59:59Z'
packages:
- product_id: 'test-product'
Expand Down Expand Up @@ -1096,7 +1096,7 @@ phases:
operator: 'pinnacle-agency.example'
brand:
domain: 'acmeoutdoor.example'
start_time: '2026-04-01T00:00:00Z'
start_time: '2027-06-01T00:00:00Z'
end_time: '2026-06-30T23:59:59Z'
packages:
- product_id: 'test-product'
Expand Down Expand Up @@ -1227,7 +1227,7 @@ phases:
operator: 'pinnacle-agency.example'
brand:
domain: 'acmeoutdoor.example'
start_time: '2026-04-01T00:00:00Z'
start_time: '2027-06-01T00:00:00Z'
end_time: '2026-06-30T23:59:59Z'
packages:
- product_id: 'test-product'
Expand Down
Loading