fix(storyboards): advance hardcoded 2026-04-01 past dates to 2027-06-01#3285
Draft
fix(storyboards): advance hardcoded 2026-04-01 past dates to 2027-06-01#3285
Conversation
Conformant sellers that enforce INVALID_REQUEST for past start_time were correctly rejecting storyboard create_media_buy requests before the test scenario could reach the intended assertion (e.g. GOVERNANCE_DENIED). This made every affected storyboard fail against correct implementations. No dynamic date DSL exists in the runner yet ($generate:uuid_v4 is the only substitution form). Bumping to 2027-06-01 restores correctness across 20 files. Test-vector JCS hashes and the sales-social event_time (a historical conversion event, semantically past) are left unchanged. Closes #2653 https://claude.ai/code/${CLAUDE_CODE_REMOTE_SESSION_ID}
bokelley
added
the
claude-triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2653
The
governance_deniedandgovernance_denied_recoverystoryboards (and 18 more) contain hardcodedstart_time: "2026-04-01T00:00:00Z"which is now in the past. Conformant seller agents that correctly enforceINVALID_REQUESTfor past start times were rejecting requests before the scenario could reach its intended assertion (e.g.,GOVERNANCE_DENIED), causing false failures against correct implementations.20 files updated — all
start_time,flight.start, and campaignstart_datefields using2026-04-01or2026-04-07bumped to2027-06-01T00:00:00Z.Left unchanged:
test-vectors/plan-hash/*.json— dates are embedded injcs_bytescanonical serializations; changing them would break the hash assertionssales-social/index.yamlevent_time: "2026-04-05T14:30:00Z"— this is a historical conversion event timestamp; past values are semantically correct for event loggingNon-breaking justification: Test fixture data change only; no schema, protocol, or API surface altered.
Follow-up needed: A
$generate:future_date:Nsubstitution form in the storyboard runner would eliminate this class of rot permanently. The only current substitution forms are$generate:uuid_v4and$context.<name>. Filed as a note in the changeset description.Pre-PR review:
$generate:future_datefollow-on recommendedgovernance-spend-authority/denied.yamlprecedent (2027-01-01); idempotency key nit noted (stable string keys instead of$generate:uuid_v4) — out of scope for this PRSession: https://claude.ai/code/${CLAUDE_CODE_REMOTE_SESSION_ID}
Generated by Claude Code