Skip to content

Support additional Room AC configurations#2056

Closed
nickolas-deboom wants to merge 2 commits intomainfrom
support-additional-air-conditioner-configurations
Closed

Support additional Room AC configurations#2056
nickolas-deboom wants to merge 2 commits intomainfrom
support-additional-air-conditioner-configurations

Conversation

@nickolas-deboom
Copy link
Copy Markdown
Contributor

Add additional profiles and handling for Room AC with support for heating-only or cooling-only.

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Add additional profiles and handling for Room AC with support for
heating-only or cooling-only.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2025

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2025

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2025

Test Results

   67 files    436 suites   0s ⏱️
2 240 tests 2 240 ✅ 0 💤 0 ❌
3 834 runs  3 834 ✅ 0 💤 0 ❌

Results for commit ccf80e2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2025

File Coverage
All files 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 87%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 95%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against ccf80e2

@hcarter-775
Copy link
Copy Markdown
Contributor

can we close this PR?

@hcarter-775
Copy link
Copy Markdown
Contributor

I'm gonna close this one @nickolas-deboom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants