Matter Thermostat: add support for modular profiles

[ctowns]

Check all that apply

Type of Change

• WWST Certification Request
  • If this is your first time contributing code:
    • I have reviewed the README.md file
    • I have reviewed the CODE_OF_CONDUCT.md file
    • I have signed the CLA
  • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
• Bug fix
• New feature
• Refactor

Checklist

• I have performed a self-review of my code
• I have commented my code in hard-to-understand areas
• I have verified my changes by testing with a device or have communicated a plan for testing
• I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Added unit tests for common device configs for Air Purifers, Thermostats, and Room ACs
Onboarded VDA devices for each of these device types
Completed test plan as defined in REQ

[github-actions]

Channel deleted.

[github-actions]

Test Results

   67 files    439 suites   0s ⏱️
2 244 tests 2 244 ✅ 0 💤 0 ❌
3 836 runs  3 836 ✅ 0 💤 0 ❌

Results for commit c3642d3.

♻️ This comment has been updated with latest results.

[github-actions]

File	Coverage
All files	88%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua	95%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua	88%	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against c3642d3

[github-actions]

Duplicate profile check: Passed - no duplicate profiles detected.

[hcarter-775]

I believe some logic may be needed to introduce this value configuration for thermostatOperatingState that we have in the static profiles, where a device might support all 3, or just idle and cooling / idle and heating

    config:
      values:
        - key: "thermostatOperatingState.value"
          enabledValues:
            - idle
            - cooling
            - heating

[ctowns]

I believe some logic may be needed to introduce this value configuration for thermostatOperatingState that we have in the static profiles, where a device might support all 3, or just idle and cooling / idle and heating

    config:
      values:
        - key: "thermostatOperatingState.value"
          enabledValues:
            - idle
            - cooling
            - heating

This is something that will be addressed by the new supportedValues attributes we added to capabilities right? I don't think we should define config values in modular profiles if we don't have to, because then they are no longer generic.

[hcarter-775]

I believe some logic may be needed to introduce this value configuration for thermostatOperatingState that we have in the static profiles, where a device might support all 3, or just idle and cooling / idle and heating

    config:
      values:
        - key: "thermostatOperatingState.value"
          enabledValues:
            - idle
            - cooling
            - heating

This is something that will be addressed by the new supportedValues attributes we added to capabilities right? I don't think we should define config values in modular profiles if we don't have to, because then they are no longer generic.

@ctowns we have not added a supported values attribute to this capability yet. Once we do, I agree that this is the way forward, and given this need for it in modular profiles, it should be done soon. In the meantime, should we do the above configure value in the profile anyway? This will at least cut down on the number of values seen, even if it's not completely accurate, and we can remove it when the supported values work is complete.

[hcarter-775]

@ctowns sorry to keep going on this topic, but it turns out I did create the supportedOperatingStates attribute for the ThermostatOperatingState capability and completely forgot, so you were totally right initially. It may be good to put any new handling we want to add that utilizes this in this PR

[ctowns]

Rebased, but no merge conflicts.

[ctowns]

Squashed and rebased, no merge conflicts.

[hcarter-775]

Looks good to me! I think we have a couple action items coming out of this PR:

1. Use supportedValues for the ThermostatOperatingState capability
2. Re-work the driver to break down some code into separate files / sub-drivers
3. Include the on/off switch in air purifiers.

Anything else to log for next steps?

[ctowns]

Looks good to me! I think we have a couple action items coming out of this PR:

1. Use supportedValues for the ThermostatOperatingState capability

2. Re-work the driver to break down some code into separate files / sub-drivers

3. Include the on/off switch in air purifiers.

Anything else to log for next steps?

This looks good to me, thank you for logging this @hcarter-775 !

[ldeora]

My thermostat radiator valves (former profile thermostat-heating-only) look like this now:

Devices with supportedThermostatModes off and heat shouldn't have thermostatCoolingSetpoint.coolingSetpoint, right?