Skip to content

Bugfix/lgXne_Si timestep controls #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentVanlaer merged 1 commit into from
Apr 11, 2026
+20 −19
Merged

Bugfix/lgXne_Si timestep controls #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docs/source/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,10 @@ Colors
Other
~~~~~

- realigned first row of headers in terminal output after changing ``lg_Lnuc`` to ``lg_Lnuc_tot``
- incorrect EoS blending near some FreeEoS edges `(gh-911) <https://github.com/MESAHub/mesa/issues/911>`_.
- kinetic energy calculations did not take ``mass_correction`` fully into account `(gh-913) <https://github.com/MESAHub/mesa/issues/913>`_.
- Realigned first row of headers in terminal output after changing ``lg_Lnuc`` to ``lg_Lnuc_tot``
- Incorrect EoS blending near some FreeEoS edges `(gh-911) <https://github.com/MESAHub/mesa/issues/911>`_.
- Kinetic energy calculations did not take ``mass_correction`` fully into account `(gh-913) <https://github.com/MESAHub/mesa/issues/913>`_.
- Fixed a bug in ``star/private/timestep.f90`` where the ``delta_lg_XNe_cntr`` and ``delta_lg_XSi_cntr`` timestep controls were incorrectly checking the central ``o16`` abundance instead of ``ne20`` and ``si28``. See `gh-963 <https://github.com/MESAHub/mesa/pull/963>`_.

Changes in r25.12.1
===================
Expand Down
32 changes: 16 additions & 16 deletions star/private/timestep.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,26 +1619,26 @@ integer function check_lg_XNe_cntr(s, skip_hard_limit, dt_limit_ratio)
logical, intent(in) :: skip_hard_limit
real(dp), intent(inout) :: dt_limit_ratio
real(dp) :: relative_excess, lg_XNe_cntr, lg_XNe_cntr_old
integer :: h1, he4, c12, o16, nz
real(dp) :: xh1, xhe4, xc12, XNe16
integer :: h1, he4, c12, ne20, nz
real(dp) :: xh1, xhe4, xc12, xne20
include 'formats'
check_lg_XNe_cntr = keep_going
if (s% mix_factor == 0d0 .and. s% dxdt_nuc_factor == 0d0) return
h1 = s% net_iso(ih1)
he4 = s% net_iso(ihe4)
c12 = s% net_iso(ic12)
o16 = s% net_iso(io16)
if (h1 == 0 .or. he4 == 0 .or. c12 == 0 .or. o16 == 0) return
ne20 = s% net_iso(ine20)
if (h1 == 0 .or. he4 == 0 .or. c12 == 0 .or. ne20 == 0) return
nz = s% nz
xh1 = s% xa(h1,nz)
xhe4 = s% xa(he4,nz)
xc12 = s% xa(c12,nz)
XNe16 = s% xa(o16,nz)
if (XNe16 < max(xh1, xhe4, xc12, 1d-10)) return
lg_XNe_cntr = log10(XNe16)
xne20 = s% xa(ne20,nz)
if (xne20 < max(xh1, xhe4, xc12, 1d-10)) return
lg_XNe_cntr = log10(xne20)
if (lg_XNe_cntr > s% delta_lg_XNe_cntr_max) return
if (lg_XNe_cntr < s% delta_lg_XNe_cntr_min) return
lg_XNe_cntr_old = safe_log10(s% xa_old(o16,nz))
lg_XNe_cntr_old = safe_log10(s% xa_old(ne20,nz))
if (s% delta_lg_XNe_drop_only .and. lg_XNe_cntr >= lg_XNe_cntr_old) return
check_lg_XNe_cntr = check_change(s, lg_XNe_cntr - lg_XNe_cntr_old, &
s% delta_lg_XNe_cntr_limit, s% delta_lg_XNe_cntr_hard_limit, &
Expand Down Expand Up @@ -1693,26 +1693,26 @@ integer function check_lg_XSi_cntr(s, skip_hard_limit, dt_limit_ratio)
logical, intent(in) :: skip_hard_limit
real(dp), intent(inout) :: dt_limit_ratio
real(dp) :: relative_excess, lg_XSi_cntr, lg_XSi_cntr_old
integer :: h1, he4, c12, o16, nz
real(dp) :: xh1, xhe4, xc12, XSi16
integer :: h1, he4, c12, si28, nz
real(dp) :: xh1, xhe4, xc12, xsi28
include 'formats'
check_lg_XSi_cntr = keep_going
if (s% mix_factor == 0d0 .and. s% dxdt_nuc_factor == 0d0) return
h1 = s% net_iso(ih1)
he4 = s% net_iso(ihe4)
c12 = s% net_iso(ic12)
o16 = s% net_iso(io16)
if (h1 == 0 .or. he4 == 0 .or. c12 == 0 .or. o16 == 0) return
si28 = s% net_iso(isi28)
if (h1 == 0 .or. he4 == 0 .or. c12 == 0 .or. si28 == 0) return
nz = s% nz
xh1 = s% xa(h1,nz)
xhe4 = s% xa(he4,nz)
xc12 = s% xa(c12,nz)
XSi16 = s% xa(o16,nz)
if (XSi16 < max(xh1, xhe4, xc12, 1d-10)) return
lg_XSi_cntr = log10(XSi16)
xsi28 = s% xa(si28,nz)
if (xsi28 < max(xh1, xhe4, xc12, 1d-10)) return
lg_XSi_cntr = log10(xsi28)
if (lg_XSi_cntr > s% delta_lg_XSi_cntr_max) return
if (lg_XSi_cntr < s% delta_lg_XSi_cntr_min) return
lg_XSi_cntr_old = safe_log10(s% xa_old(o16,nz))
lg_XSi_cntr_old = safe_log10(s% xa_old(si28,nz))
if (s% delta_lg_XSi_drop_only .and. lg_XSi_cntr >= lg_XSi_cntr_old) return
check_lg_XSi_cntr = check_change(s, lg_XSi_cntr - lg_XSi_cntr_old, &
s% delta_lg_XSi_cntr_limit, s% delta_lg_XSi_cntr_hard_limit, &
Expand Down
Loading