Bugfix/lgXne_Si timestep controls#963
Merged
VincentVanlaer merged 1 commit intor25.12.1_colors_updatedfrom Apr 11, 2026
Merged
Conversation
Debraheem
changed the title
Debraheem
changed the title
Debraheem
requested review from
JMombarg,
VincentVanlaer,
mathren and
matthiasfabry
Member
Author
|
Need two reviews to merge. |
VincentVanlaer
approved these changes
Apr 11, 2026
Member
VincentVanlaer
left a comment
VincentVanlaer
left a comment
There was a problem hiding this comment.
I looked through the other checks, but did not find any that also needed changes.
VincentVanlaer
requested review from
annethoul,
evbauer,
fxt44,
mjoyceGR,
orlox,
rsmolec and
warrickball
as code owners
VincentVanlaer
force-pushed
the
Bugfix/lgXNe_timestep_controls
branch
from
1abe76d to
583ba18
Compare
VincentVanlaer
force-pushed
the
Bugfix/lgXNe_timestep_controls
branch
from
583ba18 to
151892c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@carlnotsagan found this bug, we might want to double check for other composition driven timestep controls.
From carl:
Describe the bug
Some timestepping controls use the wrong isotope to check for return. This can result in timestep limiters never satisfying the min set before being allowed to increase. Thanks to Maria Mutz for pointing this out to me!
To Reproduce
Run a CCSN progenitor model with all fuel depletion flags on and MESA will write that the timestep is being limited by retry: delta_lg_XNe_cntr hard limit even once depleting beyond delta_lg_XNe_cntr_min.
Expected behavior
The timestep controls should shut off once the min has been satisfied.