Conversation
|
/morph test |
|
Build failures in the CI logs, please review |
|
Most of the commits look fine, need to review them in more detail. One is adding new functionality: 2b61b1f , shouldn't this be in separate PR? |
|
/morph test |
|
Good point about the new hooks in 2b61b1f, I'll pull that into a separate PR. There are a few other changes that I'll pull out, as well. |
|
Split out several changes to new branches. They'll be merged after this one. |
|
/morph test |
|
Nothing more refreshing then a big batch of refactor. |
|
/morph test |
|
Mac and Win failed with: Linux failed with a USB timeout while testing CDC. |
|
/morph test |
1 similar comment
|
/morph test |
|
The Linux tests are consistently failing (ignoring the apparent hw problems with Mac and Win), so there must be some problem introduced by this PR. I'm going to continue to break changes out from this one so the issue can hopefully be isolated. |
- Changed ELEMENTS_IN_ARRAY() to use ARRAY_SIZE(). - Using single definition of MAX().
|
Rebased and dropped the changes that are now in #692 (and which seem to be causing trouble). |
|
/morph test |
1 similar comment
|
/morph test |
main.hheaders.macro.hintoutil.hARRAY_SIZE()macro toutil.h, replacingELEMENTS_IN_ARRAY().MAX()fromutil.h.disc_sizeconstant invfs_user.cto a macro.g_families(so entries in that array can be null without terminating the list).