Merged
Conversation
- Renamed board_info_t::infoVersion to info_version. - Defined kBoardInfoVersion enum. - Corrected info_version in default g_board_info. - Set info_version on all boards to kBoardInfoVersion. # Conflicts: # source/target/target_board.h
Collaborator
Author
|
/morph test |
Collaborator
Author
|
Mac and Windows CI still have the unavailable board issue, but Linux passed so I'm merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
board_info_t::infoVersionmember was intended to be used as the version number for theboard_info_tstruct itself, not the version of the board. This is important to ensure that board info added via post-processing a firmware binary has a known format. This PR clarifies and standardizes the usage of this version member.Defined a
kBoardInfoVersionconstant (currently equal to 1), and set it as the current version in all definedboard_info_tstructures. Also renamedinfoVersiontoinfo_version. The interface main task asserts thatg_board_info.info_versionis valid.(Extracted from #688.)