zulip_bots: Fix react() in StubBotHandler to pass full reaction data#914
Open
JordanKapala wants to merge 1 commit intozulip:mainfrom
Open
zulip_bots: Fix react() in StubBotHandler to pass full reaction data#914JordanKapala wants to merge 1 commit intozulip:mainfrom
JordanKapala wants to merge 1 commit intozulip:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating #790 (bot_handler.react only working in private messages),
I found an inconsistency in StubBotHandler.react() in test_lib.py that could
cause bots to behave differently in tests vs. production.
The react() method in StubBotHandler was passing only emoji_name to
message_server.add_reaction(), while the real ExternalBotHandler and
TerminalBotHandler implementations both pass the full reaction dict including
message_id and reaction_type. Additionally, mock messages constructed by
make_request_message() were missing an id field, which would cause any bot
test exercising react() to raise a KeyError.
Fixes: #790 (partial - fixes test framework inconsistency found while investigating)
How did you test this PR?
Ran the full test suite: 413 passed, 0 failed. (previously 2 failed)
Verified ruff and mypy report no issues on test_lib.py.