Consolidate iteration into one implementation#146
Open
sbquinlan wants to merge 6 commits intozslayton:masterfrom
Open
Consolidate iteration into one implementation#146sbquinlan wants to merge 6 commits intozslayton:masterfrom
sbquinlan wants to merge 6 commits intozslayton:masterfrom
Conversation
Contributor
Author
|
Stacked on #145 |
sbquinlan
force-pushed
the
codex/query-iteration-cleanup
branch
from
d7b726e to
bf59afa
Compare
sbquinlan
force-pushed
the
codex/query-iteration-cleanup
branch
from
bf59afa to
f6fd332
Compare
sbquinlan
force-pushed
the
codex/query-iteration-cleanup
branch
from
f6fd332 to
c6ec078
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a TODO in the query file to reduce the query structs into one that's agnostic of iteration direction. I think at this point the schedule iteration is more complicated and repeated than the query. So what I did is make the schedule iteration agnostic of direction by moving more of the "directionality" into the query structs.