Conversation
|
augment review |
🤖 Augment PR SummarySummary: This PR refines zopen’s build/install flow by improving how dependencies are represented and how environment setup is generated during builds. Changes:
Technical Notes: The new 🤖 Was this summary useful? React with 👍 or 👎 |
|
augment review |
|
augment review |
sachintu47
force-pushed
the
buildimprov
branch
3 times, most recently
from
c73ccb0 to
cb8a6e4
Compare
…ncies This commit implements a streamlined environment separation strategy for zopen-build and zopen-generate, focusing on a single-variable signal (ZOPEN_IN_ZOPEN_BUILD) to differentiate between build-time and runtime environments. Key changes: - Combined installDeps and sourceDepsEnv into a unified setDepsEnv function in bin/zopen-build for atomic dependency handling. - Implemented support for the pkg:bin dependency format by temporarily unsetting ZOPEN_IN_ZOPEN_BUILD during sourcing in setDepsEnv. - Updated createEnvAndSetup to guard PKG_CONFIG_PATH in generated .env files with a ZOPEN_IN_ZOPEN_BUILD check, ensuring dev paths are only added during build-time sourcing. - Simplified .depsenv generation to rely on natural environment propagation of the build signal, removing redundant save/restore logic. - Updated normalizeDeps in include/common.sh to ensure full dependencies take precedence over :bin requests. - Restored zopen-generate templates to use zopen_append_to_env with ZOPEN_IN_ZOPEN_BUILD guards for build-only flags (CFLAGS, LDFLAGS, etc.). - Fixed a persistent 'isWritable' typo in generated setup scripts. These changes ensure that runtime environments for packages remain clean while providing all necessary development flags during the build process of dependent ports.
|
augment review |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| if [ ! -z "\${ZOPEN_IN_ZOPEN_BUILD}" ]; then | ||
| if [ -d "\${${projectName}_HOME}/lib/pkgconfig" ]; then | ||
| PKG_CONFIG_PATH="\${${projectName}_HOME}/lib/pkgconfig:\$PKG_CONFIG_PATH" | ||
| export PKG_CONFIG_PATH="\$(deleteDuplicateEntries "\$PKG_CONFIG_PATH" ":")" |
There was a problem hiding this comment.
The generated .env line export PKG_CONFIG_PATH="$(deleteDuplicateEntries ...)" contains unescaped nested quotes (e.g., "$PKG_CONFIG_PATH" / ":"), which will make .env fail to source with a shell syntax error. This looks like it should be a single properly-quoted command substitution string in the output file.
Severity: high
Other Locations
bin/zopen-build:1757
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
1 participant
What type of PR is this? (check all applicable)
Category
Description
Related Issues
[optional] Are there any post-deployment tasks or follow-up actions required?