Skip to content

allow ellipsis#312

Merged
dataflake merged 1 commit intozopefoundation:masterfrom
zedzhen:ellipsis
Apr 25, 2026
Merged

allow ellipsis#312
dataflake merged 1 commit intozopefoundation:masterfrom
zedzhen:ellipsis

Conversation

@zedzhen
Copy link
Copy Markdown
Contributor

@zedzhen zedzhen commented Apr 24, 2026

  • I signed and returned the Zope Contributor Agreement, and received and accepted an invitation to join a team in the zopefoundation GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Developer guidelines. (I can't create branches, so I use a fork. All other recommendations have been followed.)
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

Closes #311

@dataflake
Copy link
Copy Markdown
Member

Ellipsis seems to have been removed for a reason. Have you looked at 61d26b3 and the referred https://bugs.python.org/issue36917#msg342583?

@zedzhen
Copy link
Copy Markdown
Contributor Author

zedzhen commented Apr 24, 2026

I looked. It was allowed at #150 because they didn't know how to disallowed it. In #171, it was disallowed because they found a good way to disallow it back. There were no specific reasons for the disallow.

Copy link
Copy Markdown
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading up on the Ellipsis type, which is just a constant, this should be safe.

@dataflake dataflake merged commit 3c1a229 into zopefoundation:master Apr 25, 2026
17 checks passed
@zedzhen zedzhen deleted the ellipsis branch April 25, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Ellipsis

2 participants