[crypto] Update otcrypto_interface.h and backport map file analysis #230
Draft
mkannwischer wants to merge 2 commits intomasterfrom
Draft
[crypto] Update otcrypto_interface.h and backport map file analysis #230mkannwischer wants to merge 2 commits intomasterfrom
otcrypto_interface.h and backport map file analysis #230mkannwischer wants to merge 2 commits intomasterfrom
Conversation
Contributor
Author
|
Double checked that this actually fails in CI, it does: https://github.com/zerorisc/expo/actions/runs/23638376086/job/68852970748?pr=230 |
The otcrypto_export_size binary was not previously built in CI and causing us to not notice that it was out of sync with the cryptolib API. This commit updates `otcrypto_interface.h`. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
This PR contains necessary updates to allow for building the map file of the whole crypto lib and then use the map file to hjson python script to create a visual representation of the map file for easier analysis of the memory usage. Co-authored-by: Chris Frantz <cfrantz@google.com> Signed-off-by: Hakim Filali <hfilali@lowrisc.org>
mkannwischer
force-pushed
the
fix-code-size-measurement
branch
from
69ed63f to
9fed0a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
otcrypto_interface.his outdated (e.g., it was not updated in #204) -otcrypto_export_size, hence, fails to compile.This fixes that and also backports a changes to allow cryptolib map file analysis which as a side effect also causes this test to be picked up by our CI (at least that is what I hope - testing now).