[ci,acc] Adds support for ACC PQC smoke test in Verilator and adds it to CI#217
Open
[ci,acc] Adds support for ACC PQC smoke test in Verilator and adds it to CI#217
Conversation
991fbca to
c579fb5
Compare
Added PQC support to verilator environment by adding a KMAC to the testbench and extending the fusesoc core. Replaced the old use of a global environment variable to configure the ISS wrapper model with a -CFLAG for build time changes. Updated the existing DV simulation configs to comply with the new configuration method. Signed-off-by: Evan Apinis <eapinis@zerorisc.com>
c579fb5 to
deb127d
Compare
Standalone Verilator warnings from PQC mode enabled were removed with waivers and/or updating the RTL. Most warnings are from the addition of KMAC which has combinational assignements from struct ports. Additional waivers were made for prim IP related issues. Signed-off-by: Evan Apinis <eapinis@zerorisc.com>
Signed-off-by: Evan Apinis <eapinis@zerorisc.com>
deb127d to
c170aa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restructures the previous configuration for passing the PQC parameter from a simulation config to the DV environment.
iss_wrapper.ccat build time which will create theaccsimISS model.--flag pqcto configure the ACC instantiation and appropriate core dependencies/-CFLAG options.It also updates the
smoke_pqcdirectory to use the appropriate fusesoc invocation and integrates into CIUNUSEDfor signals in the top-level testbench used for visibility,UNOPTFLATfor combinational assignments to struct fields that rely on the value of other fields in the same struct, andVARHIDDENfor having multiple FSM in KMAC that share state names in their enum declarations.smoke_pqc/smoke_test.sresults based on model behavior after adding a KMAC transaction and the vector instructions.The existing
ci.ymlfile had a typo inOTBNhaving been namedOBTNand the name was updated toACC. The same typo existed in thesw/device/tests/penetrationtests/firmware/fi/acc/*.sassembly files and has been updated as well.