Skip to content

feat(contracts): add CI workflow to check contract selectors consistency#112

Open
Seth-Schmidt wants to merge 3 commits intomainfrom
feature/pro-349-chorecontracts-add-contract-selector-check-to-ci
Open

feat(contracts): add CI workflow to check contract selectors consistency#112
Seth-Schmidt wants to merge 3 commits intomainfrom
feature/pro-349-chorecontracts-add-contract-selector-check-to-ci

Conversation

@Seth-Schmidt
Copy link
Copy Markdown
Contributor

@Seth-Schmidt Seth-Schmidt commented Apr 16, 2026

Summary

  • Adds a new contracts-check-selectors GitHub Actions workflow that runs make check-selectors on PRs touching Solidity files and on pushes to main, ensuring selectors.txt stays in sync with compiled contract selectors across all contract packages.
  • Fixes a shell portability issue in contracts/Makefile: replaces &> /dev/null with > /dev/null 2>&1 for POSIX compatibility.

@cla-bot cla-bot Bot added the cla-signed label Apr 16, 2026
…aching for node_modules

* Added installation step for forge-std in the contracts/staking directory.
* Implemented caching for node_modules across multiple contract packages to improve workflow efficiency.
* Updated Makefile to redirect diff output for better error handling during selector checks.
@Seth-Schmidt Seth-Schmidt force-pushed the feature/pro-349-chorecontracts-add-contract-selector-check-to-ci branch from 671622f to 2be4362 Compare April 17, 2026 18:57
@Seth-Schmidt Seth-Schmidt marked this pull request as ready for review April 17, 2026 19:01
@Seth-Schmidt Seth-Schmidt requested review from a team and mortendahl as code owners April 17, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant