Skip to content

Promote the constant pool pointer.#144

Merged
vext01 merged 1 commit intoykjit:mainfrom
ltratt:promote_k
Mar 24, 2026
Merged

Promote the constant pool pointer.#144
vext01 merged 1 commit intoykjit:mainfrom
ltratt:promote_k

Conversation

@ltratt
Copy link
Copy Markdown
Contributor

@ltratt ltratt commented Mar 24, 2026

This is constant for every Proto, so promoting it allows us to optimise some stuff out of the trace.

@vext01 vext01 added this pull request to the merge queue Mar 24, 2026
@vext01
Copy link
Copy Markdown
Contributor

vext01 commented Mar 24, 2026

Nice. Any speedup measured?

@ltratt
Copy link
Copy Markdown
Contributor Author

ltratt commented Mar 24, 2026

Oops yes:

 permute/lua/1000         7982 ± 903   6434 ± 354   0.81  19.39% faster
 towers/lua/600           7491 ± 573   6382 ±  94   0.85  14.80% faster
 bounce/lua/1500          8406 ± 241   7657 ± 223   0.91  8.91% faster
 deltablue/lua/12000      8058 ± 295   7657 ±  96   0.95  4.98% faster
 Heightmap/lua/2000       6880 ±   5   6713 ±   9   0.98  2.43% faster

permute is very nondeterministic but that does seem to be real.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2026
@vext01
Copy link
Copy Markdown
Contributor

vext01 commented Mar 24, 2026

that's good!

This is constant for every `Proto`, so promoting it allows us to
optimise some stuff out of the trace.
@ltratt
Copy link
Copy Markdown
Contributor Author

ltratt commented Mar 24, 2026

(Hopefully) fixed the non-yk-compilation build errors in the force push.

@vext01 vext01 added this pull request to the merge queue Mar 24, 2026
Merged via the queue into ykjit:main with commit b7e91b6 Mar 24, 2026
2 checks passed
@ltratt ltratt deleted the promote_k branch March 24, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants