Skip to content

wires the OpenMLS AppDataUpdate flow into the per-field metadata path#3460

Draft
tylerhawkes wants to merge 1 commit intoapp-data-permissionsfrom
app-data-bridge
Draft

wires the OpenMLS AppDataUpdate flow into the per-field metadata path#3460
tylerhawkes wants to merge 1 commit intoapp-data-permissionsfrom
app-data-bridge

Conversation

@tylerhawkes
Copy link
Copy Markdown
Contributor

@tylerhawkes tylerhawkes commented Apr 10, 2026

Wire OpenMLS AppDataUpdate proposals into the per-field metadata path

  • Adds crates/xmtp_mls/src/groups/app_data/ with helpers to accumulate, encode, apply, and validate AppDataUpdate proposals against an OpenMLS AppData dictionary.
  • Adds component_source.rs to centralize per-ComponentId read/encode/apply logic, bridging the new AppData dictionary and legacy group context extensions.
  • Group::sync now routes metadata updates through inline AppDataUpdate commits (instead of legacy GCE updates) when proposals are enabled and a non-empty ComponentRegistry is present.
  • ValidatedCommit::from_staged_commit validates inline AppDataUpdate proposals against component permissions, rejecting commits from unauthorized proposers.
  • Group::mutable_metadata overlays AppData dictionary values on top of legacy extension values so callers see a unified view.
  • Key packages and newly created groups now advertise AppDataUpdate proposal support in their capabilities.
  • Behavioral Change: metadata update commits follow the AppData path when the registry is non-empty and proposals are enabled; groups without a registry or with proposals disabled continue to use the legacy path.

Macroscope summarized 586de5b.

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label mergequeue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant