Fix graphs on new architecture with interop layer#1007
Open
MaxToyberman wants to merge 5 commits intowuxudong:masterfrom
Open
Fix graphs on new architecture with interop layer#1007MaxToyberman wants to merge 5 commits intowuxudong:masterfrom
MaxToyberman wants to merge 5 commits intowuxudong:masterfrom
Conversation
|
BarChart don't working, LineChart work |
It's work for me, for BarChart |
|
we need to add these lines to each chart kind (Line, bar, pie... etc) |
|
Can someone merge this please? confirmed this PR works with the latest RN and Expo |
chriscarex
approved these changes
Jan 23, 2025
|
This is just for iOS. we are facing issue of Warning: TypeError: Cannot read property 'bubblingEventTypes' of null in Android. so do you have any idea on it. @MaxToyberman |
valntyn
approved these changes
Nov 19, 2025
Contributor
|
What also stopped working is this for cleaning highlights: chartRef.current.highlights([])Had to fix it by: func _highlights(_ reactTag: NSNumber, config: NSArray) {
_bridge?.uiManager.addUIBlock { (uiManager: RCTUIManager?, _) in
guard let view = uiManager?.view(forReactTag: reactTag) as? RNBarLineChartViewBase,
let barLineChart = view.chart as? BarLineChartViewBase
else {
return
}
barLineChart.highlightValues(HighlightUtils.getHighlights(config))
}
}And: const node = findNodeHandle(chartRef.current);
if (!node) {
return;
}
const { Commands } = UIManager.getViewManagerConfig('RNLineChart');
if (isNil(Commands.highlights)) {
return;
}
UIManager.dispatchViewManagerCommand(node, Commands.highlights, [[]]); |
angelos3lex
added a commit
to angelos3lex/react-native-charts-wrapper
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.