Provide support to add named configs map for authenticators#4363
Draft
sahandilshan wants to merge 3 commits intowso2:4.10.xfrom
Draft
Provide support to add named configs map for authenticators#4363sahandilshan wants to merge 3 commits intowso2:4.10.xfrom
sahandilshan wants to merge 3 commits intowso2:4.10.xfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for named configuration maps in authenticators, allowing configurations to be organized in named groups rather than just flat parameter maps. This enables more structured configuration management for authenticators while maintaining backward compatibility with existing flat parameter configurations.
Key changes:
- Introduces a nested parameter map structure alongside the existing flat parameter map
- Adds processing logic to handle both named and unnamed configuration elements
- Provides new getter methods to access named configurations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| // Only process configs that have an explicit name attribute. | ||
| OMAttribute configNameAttr = configElement.getAttribute(new QName(ATTR_NAME)); | ||
| if(configNameAttr == null){ |
|
|
||
| // Only process configs that have an explicit name attribute. | ||
| OMAttribute configNameAttr = configElement.getAttribute(new QName(ATTR_NAME)); | ||
| if(configNameAttr == null){ |
Member
There was a problem hiding this comment.
It unclear what are we trying to achieve here.
Author
There was a problem hiding this comment.
Currently we can have define as below
<Config>
<Parameter name="name01">value01</Parameter>
<Parameter name="name02">value02</Parameter>
</Config>
With this new config we are providing the support to define named config along with the previous support. so now we can have something like this
<Config>
<Parameter name="name01">value01</Parameter>
<Parameter name="name02">value02</Parameter>
</Config>
<Config name="configName">
<Parameter name="name01">value01</Parameter>
<Parameter name="name02">value02</Parameter>
</Config>
| OMAttribute configNameAttr = configElement.getAttribute(new QName(ATTR_NAME)); | ||
| if(configNameAttr == null){ | ||
| // Skip configs without name attribute - process parameters for flat map only. | ||
| for(Iterator paramIterator = configElement.getChildrenWithLocalName(ELEM_PARAMETER); |
Member
There was a problem hiding this comment.
Can we avoid iterating the elements twice?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
With this new support we can define new configurations for Authenticators as below.