Initial work on supporting the Winter.Blog plugin#4
Draft
LukeTowers wants to merge 1 commit intomainfrom
Draft
Conversation
Thoughts for further development: We should add a Winter\SEO\Behaviours\SeoableModel model behavior that makes it easier to configure the meta data (meta, link, & structured data) that a model provides by providing configuration through model properties and standard getSeoDataAttribute() / setSeoDataAttribute() methods that can be overridden or just configured by the model properties.
|
Any news regarding this? |
Member
Author
|
@01Kuzma I haven't needed to touch this for a while to finish it or even check in on what's left to finish. If you test out this PR and confirm that it works then I'm happy to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thoughts for further development:
We should add a Winter\SEO\Behaviours\SeoableModel model behavior that makes it easier to configure the meta data (meta, link, & structured data) that a model provides by providing configuration through model properties and standard getSeoDataAttribute() / setSeoDataAttribute() methods that can be overridden or just configured by the model properties.
Initial work for #3